Skip to content

Multiple odo fixes. #32602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2021
Merged

Multiple odo fixes. #32602

merged 1 commit into from
May 21, 2021

Conversation

yhontyk
Copy link
Contributor

@yhontyk yhontyk commented May 18, 2021 •
edited
Loading

Fixes #32436
Fixes #32439
Fixes #32435

Branch 4.7 and 4.8

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 18, 2021
@netlify
Copy link

netlify bot commented May 18, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit 15de8f3

https://deploy-preview-32602--osdocs.netlify.app

jc-berger
jc-berger approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from docs point of view.

@Preeticp Preeticp mentioned this pull request May 20, 2021
Closed
@openshift-cherrypick-robot
Copy link

@neal-timpe: once the present PR merges, I will cherry-pick it on top of enterprise-4.7 in a new PR and assign it to you.

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe neal-timpe merged commit e4bd1a1 into openshift:master May 21, 2021
@neal-timpe
Copy link
Contributor

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 21, 2021
Merged
@openshift-cherrypick-robot
Copy link

@neal-timpe: new pull request created: #32711

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe
Copy link
Contributor

/cherry-pick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 21, 2021
Merged
@openshift-cherrypick-robot
Copy link

@neal-timpe: new pull request created: #32712

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@neal-timpe neal-timpe neal-timpe approved these changes

@jc-berger jc-berger jc-berger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

4 participants

@yhontyk @openshift-cherrypick-robot @neal-timpe @jc-berger