Skip to content

Conversation

sounix000
Copy link
Contributor

@sounix000 sounix000 commented Jun 9, 2021

Note for @Preeticp : I have manually checked the Pipelines pages in the enterprise-4.6 branch that are most likely to be affected by this change. All of them contains {pipelines-ver}, and none of them contains hard-coded pipelines version (1.2), so I think we are good with the tiny change in the attribute file.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 9, 2021
@netlify
Copy link

netlify bot commented Jun 9, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 952bc39

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60d4a326e46e5200081451b3

😎 Browse the preview: https://deploy-preview-33246--osdocs.netlify.app/openshift-enterprise/latest/pipelines/creating-applications-with-cicd-pipelines

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 9, 2021
@Preeticp
Copy link
Contributor

Preeticp commented Jun 9, 2021

@sounix000 can you get a QE LGTM to the PR too, please? I checked the preview, looks good to me. Also linked the GH issue so that it will automatically close once this PR is merged.

@Preeticp
Copy link
Contributor

Preeticp commented Jun 9, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@Preeticp Preeticp added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR and removed lgtm Indicates that a PR is ready to be merged. labels Jun 9, 2021
@vikram-redhat vikram-redhat changed the title Set pipeline-ver attribute to 1.2 RHDEVDOCS-2863: Set pipeline-ver attribute to 1.2 Jun 11, 2021
Copy link

@ppitonak ppitonak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sounix000
Copy link
Contributor Author

@ppitonak, @Preeticp - Corrected, PTAL.

… docs #30052

GitHub-30095: Fixing formatting error

Modified YAML sample for EventListener necessary to add triggers.

Modified EventListener YAML based on QE feedback.

Editorial changes based on Preeti's feedback

More editorial changes

Changed the attribute pipelines-ver to pipelines-1.2

Revert "Modified YAML sample for EventListener necessary to add triggers."

This reverts commit 8ba7684.

pipelines-ver attribute set to 1.2

Revert "pipelines-ver attribute set to 1.2"

This reverts commit 7f5fb347073afe369b26ee1ea1403bdec291393f.

Revert "Modified YAML sample for EventListener necessary to add triggers."

This reverts commit 8ba7684.

pipelines-ver attribute set to 1.2

Corrected pipelines version
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2021
@Preeticp
Copy link
Contributor

@VeereshAradhya
Copy link

VeereshAradhya commented Jun 25, 2021

try this https://raw.githubusercontent.com/openshift/pipelines-tutorial/release-tech-preview-2/03_triggers/01_binding.yaml

@sounix000
Copy link
Contributor Author

Based on Pavol's comment and confirmation, I am closing this PR and the corresponding JIRA issue. The linked GitHub issue will be closed automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants