-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS-2863: Set pipeline-ver attribute to 1.2 #33246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS-2863: Set pipeline-ver attribute to 1.2 #33246
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 952bc39 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60d4a326e46e5200081451b3 😎 Browse the preview: https://deploy-preview-33246--osdocs.netlify.app/openshift-enterprise/latest/pipelines/creating-applications-with-cicd-pipelines |
@sounix000 can you get a QE LGTM to the PR too, please? I checked the preview, looks good to me. Also linked the GH issue so that it will automatically close once this PR is merged. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The very first URL that I tried is not found:
https://raw.githubusercontent.com/openshift/pipelines-tutorial/pipelines-1.2/01_pipeline/01_apply_manifest_task.yaml
… docs #30052 GitHub-30095: Fixing formatting error Modified YAML sample for EventListener necessary to add triggers. Modified EventListener YAML based on QE feedback. Editorial changes based on Preeti's feedback More editorial changes Changed the attribute pipelines-ver to pipelines-1.2 Revert "Modified YAML sample for EventListener necessary to add triggers." This reverts commit 8ba7684. pipelines-ver attribute set to 1.2 Revert "pipelines-ver attribute set to 1.2" This reverts commit 7f5fb347073afe369b26ee1ea1403bdec291393f. Revert "Modified YAML sample for EventListener necessary to add triggers." This reverts commit 8ba7684. pipelines-ver attribute set to 1.2 Corrected pipelines version
This link does not work: https://github.com/openshift/pipelines-tutorial/blob/release-tech-preview-2/03_triggers/03_trigger.yaml in Step 6 in https://deploy-preview-33246--osdocs.netlify.app/openshift-enterprise/latest/pipelines/creating-applications-with-cicd-pipelines?utm_source=github&utm_campaign=bot_dp#adding-triggers_creating-applications-with-cicd-pipelines |
Based on Pavol's comment and confirmation, I am closing this PR and the corresponding JIRA issue. The linked GitHub issue will be closed automatically. |
enterprise-4.6
pipelines-ver
attribute has been used in the branchenterprise-4.6
.Note for @Preeticp : I have manually checked the Pipelines pages in the
enterprise-4.6
branch that are most likely to be affected by this change. All of them contains{pipelines-ver}
, and none of them contains hard-coded pipelines version (1.2), so I think we are good with the tiny change in the attribute file.