Skip to content

MIG-686: PV resize #33758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2021
Merged

MIG-686: PV resize #33758

merged 1 commit into from
Jun 24, 2021

Conversation

apinnick
Copy link
Contributor

@apinnick apinnick commented Jun 22, 2021 •
edited
Loading

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2021
@netlify
Copy link

netlify bot commented Jun 22, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 9de0257

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60d499d288449700077b7790

😎 Browse the preview: https://deploy-preview-33758--osdocs.netlify.app

@apinnick apinnick force-pushed the mig686-pv-resize branch 3 times, most recently from 5c49ca6 to 3258bfb Compare June 23, 2021 14:36
@apinnick apinnick marked this pull request as ready for review June 23, 2021 14:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2021
@xinredhat
Copy link

xinredhat commented Jun 24, 2021 •
edited
Loading

@apinnick we need to consider gp2 as an exception, please see the comments in bz#1973148

@apinnick
Copy link
Contributor Author

@apinnick we need to consider gp2 as an exception, please see the comments in bz#1973148

Note added to the PR

@apinnick apinnick added qe-approved Signifies that QE has signed off on this PR branch/enterprise-4.8 peer-review-needed Signifies that the peer review team needs to review this PR and removed QE Required branch/enterprise-4.8 labels Jun 24, 2021
@hu-weihua
Copy link

LGTM

mburke5678
mburke5678 reviewed Jun 24, 2021
View reviewed changes
mburke5678
mburke5678 reviewed Jun 24, 2021
View reviewed changes
mburke5678
mburke5678 requested changes Jun 24, 2021
View reviewed changes
@mburke5678
Copy link
Contributor

@apinnick A couple of small things. Otherwise LGTM

@apinnick apinnick merged commit 5271673 into openshift:master Jun 24, 2021
@apinnick apinnick deleted the mig686-pv-resize branch June 24, 2021 15:01
@apinnick
Copy link
Contributor Author

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 24, 2021
Merged
@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #33901

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mburke5678 mburke5678 mburke5678 requested changes

Assignees

No one assigned

Labels

branch/enterprise-4.8 peer-review-needed Signifies that the peer review team needs to review this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@apinnick @xinredhat @hu-weihua @mburke5678 @openshift-cherrypick-robot