Skip to content

SRVKS-562: Restrictive network policy docs for Knative services #34700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2021
Merged

SRVKS-562: Restrictive network policy docs for Knative services #34700

merged 1 commit into from
Aug 2, 2021

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Jul 19, 2021 •
edited
Loading

@abrennan89 abrennan89 added this to the Next Release milestone Jul 19, 2021
@abrennan89 abrennan89 requested a review from nak3 July 19, 2021 16:33
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2021
@netlify
Copy link

netlify bot commented Jul 19, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 2784ed2

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6101a80727b4bb0007985717

😎 Browse the preview: https://deploy-preview-34700--osdocs.netlify.app

@nak3
Copy link
Contributor

nak3 commented Jul 19, 2021

/lgtm

Thank you!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2021
@nak3
Copy link
Contributor

nak3 commented Jul 20, 2021

/lgtm cancel

I think we need to write about https://docs.google.com/document/d/1Hsfd-DBrdBuPyzwET32D53Y33xTQ3wzPY_B_0JWnMrk/edit?disco=AAAANdx3Gv4

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2021
@abrennan89
Copy link
Contributor Author

@nak3 thanks, was just waiting for clarification about the comment. I've added a note for this now, PTAL.

@nak3
Copy link
Contributor

nak3 commented Jul 21, 2021

/lgtm
Thank you!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
abrennan89
abrennan89 commented Jul 21, 2021
View reviewed changes
@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2021
jrangelramos
jrangelramos reviewed Jul 28, 2021
View reviewed changes
Copy link
Contributor

@jrangelramos jrangelramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ one minor suggestion.

bergerhoffer
bergerhoffer reviewed Jul 28, 2021
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things, but overall looks great!

@bergerhoffer bergerhoffer added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 28, 2021
@jrangelramos
Copy link
Contributor

QE Approved

jboxman
jboxman reviewed Jul 28, 2021
View reviewed changes
jboxman
jboxman reviewed Jul 28, 2021
View reviewed changes
@abrennan89 abrennan89 requested a review from bergerhoffer July 28, 2021 18:55
@abrennan89
Copy link
Contributor Author

Thanks so much for the comments and review @jboxman @bergerhoffer
This is ready for another look now 🙂

@abrennan89 abrennan89 merged commit 7e76d68 into openshift:main Aug 2, 2021
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.6

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.7

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.8

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.9

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 2, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #35075

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 2, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #35076

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 2, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #35077

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 2, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #35078

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 deleted the SRVKS-562 branch December 17, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nak3 nak3 Awaiting requested review from nak3

@bergerhoffer bergerhoffer Awaiting requested review from bergerhoffer

2 more reviewers

@jboxman jboxman jboxman left review comments

@jrangelramos jrangelramos jrangelramos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nak3 nak3

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@abrennan89 @nak3 @jrangelramos @openshift-cherrypick-robot @jboxman @bergerhoffer