-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSSMDOC-213: Update existing federation reference. #35770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 572c731 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6137b6c76185e40007ee013e 😎 Browse the preview: https://deploy-preview-35770--osdocs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rh-tokeefe The only concern: "...cluster in which it operates". Maybe I'm lacking context or just don't understand something but it's not entirely clear to me what is meant by "it". Should it be "they" or maybe clarified further?
Thank you for the feedback @missmesss. I changed the content. In place of "in which it operates," the topic now reads "...in which the Service Mesh operates." I will submit the change and squash the commits. |
4087be7
to
7cfe274
Compare
Should this be Or is it correct to delete the entire line for 2.1. |
7cfe274
to
572c731
Compare
/cherry-pick enterprise-4.6 |
/cherry-pick enterprise-4.7 |
/cherry-pick enterprise-4.8 |
/cherry-pick enterprise-4.9 |
@JStickler: #35770 failed to apply on top of branch "enterprise-4.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JStickler: #35770 failed to apply on top of branch "enterprise-4.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JStickler: new pull request created: #36162 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JStickler: new pull request created: #36163 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Deleted one line and revised another based on story description. Changes were made for the v2 file. v1 was left unchanged.
Cherry pick to 4.6, 4.7, 4.8, and 4.9
@JStickler please let me know if you find anything I need to revise. Thanks!
Preview link: https://deploy-preview-35770--osdocs.netlify.app/openshift-enterprise/latest/service_mesh/v2x/preparing-ossm-installation.html#ossm-supported-configurations_preparing-ossm-installation