Skip to content

RHDEVDOCS-3295 Add a link to the OL 5.0.8 and 5.1.2 advisories to the 5.0 release… #36329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2021
Merged

RHDEVDOCS-3295 Add a link to the OL 5.0.8 and 5.1.2 advisories to the 5.0 release… #36329

merged 1 commit into from
Sep 24, 2021

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Sep 14, 2021 •
edited
Loading

… notes

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 14, 2021
@netlify
Copy link

netlify bot commented Sep 14, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 0a88c13

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/614da8382aae1000080a7c7c

😎 Browse the preview: https://deploy-preview-36329--osdocs.netlify.app

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2021
periklis
periklis reviewed Sep 15, 2021
View reviewed changes
Copy link

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolfedh rolfedh changed the title RHDEVDOCS-3295 Add a link to the OL 5.0.8 advisory to the 5.0 release… RHDEVDOCS-3295 Add a link to the OL 5.0.8 and 5.1.2 advisories to the 5.0 release… Sep 15, 2021
periklis
periklis reviewed Sep 15, 2021
View reviewed changes
Copy link

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like missing the 5.1.2 changelog file?!

@rolfedh
Copy link
Contributor Author

rolfedh commented Sep 15, 2021

This looks like missing the 5.1.2 changelog file?!

Yes we're adding it right now.

rolfedh
rolfedh commented Sep 16, 2021
View reviewed changes
@kabirbhartiRH
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
kowen-rh
kowen-rh reviewed Sep 22, 2021
View reviewed changes
@kowen-rh
Copy link
Contributor

The wording of this PR looks good to me from a documentation perspective. Added a single comment questioning if we should include a copy of the "making open source more inclusive" section, as I believe this section is added automatically and including it in this PR could potentially result in a duplicate section (or, in case of updated wording in the snippet of origin, out of date information).

I'm leaving this review as a comment since I cannot independently confirm whether or not this change is explicitly required. Other than that section, this PR looks good to me! 👍

Preeticp
Preeticp reviewed Sep 24, 2021
View reviewed changes
@Preeticp
Copy link
Contributor

@rolfedh apart from the one comment, looks good to me. Let me know when it is ready to be merged.

@openshift-ci
Copy link

openshift-ci bot commented Sep 24, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021
@Preeticp Preeticp added branch/enterprise-4.7 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR labels Sep 24, 2021
@Preeticp Preeticp merged commit 20d2e6a into openshift:enterprise-4.7 Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Preeticp Preeticp Preeticp left review comments

+2 more reviewers

@periklis periklis periklis left review comments

@kowen-rh kowen-rh kowen-rh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kabirbhartiRH kabirbhartiRH

Labels

branch/enterprise-4.7 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rolfedh @kabirbhartiRH @kowen-rh @Preeticp @periklis