Skip to content

Conversation

rvanderp3
Copy link
Contributor

Additional permissions are required as the base RHCOS virtual machine is now being marked as a template by the IPI installer. The intent of this PR is to add the required permissions.

@jcpowermac @bostrt

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2021
@rvanderp3 rvanderp3 changed the title Fixes 2004317: add missing template specific permissions Bug 2004317: add missing template specific permissions Sep 23, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 23, 2021

@rvanderp3: This pull request references Bugzilla bug 2004317, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2004317: add missing template specific permissions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 23, 2021

@rvanderp3: This pull request references Bugzilla bug 2004317, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jinyunma

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 23, 2021
@openshift-ci openshift-ci bot requested a review from jinyunma September 23, 2021 19:27
@netlify
Copy link

netlify bot commented Sep 23, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: b08d869

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/614cd4824378f70007b33f1a

😎 Browse the preview: https://deploy-preview-36720--osdocs.netlify.app

@bobfuru bobfuru added the peer-review-done Signifies that the peer review team has reviewed this PR label Oct 7, 2021
@bobfuru bobfuru added this to the Next Release milestone Oct 7, 2021
@bobfuru
Copy link
Contributor

bobfuru commented Oct 7, 2021

LGTM - confirmed with @GroceryBoyJr that this applies to OCP 4.8+.

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2021

@rvanderp3: All pull requests linked via external trackers have merged:

Bugzilla bug 2004317 has been moved to the MODIFIED state.

In response to this:

Bug 2004317: add missing template specific permissions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru
Copy link
Contributor

bobfuru commented Oct 7, 2021

/cherrypick enterprise-4.9

@bobfuru
Copy link
Contributor

bobfuru commented Oct 7, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@bobfuru: new pull request created: #37217

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bobfuru: new pull request created: #37218

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.8 branch/enterprise-4.9 bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants