-
Notifications
You must be signed in to change notification settings - Fork 1.8k
BZ#1948730 Add cluster-wide proxy module since now supported for IPI #37150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: cb730f0 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/615dc5e65d3b4a000739f75d 😎 Browse the preview: https://deploy-preview-37150--osdocs.netlify.app |
@jianli-wei can you verify? Thanks! |
@codyhoag It looks good, but there's a documentation bug on the existing statements of proxy settings, i.e. https://bugzilla.redhat.com/show_bug.cgi?id=1986701, so if possible, I suggest to remove the statement "If this field is not specified, then httpProxy is used for both HTTP and HTTPS connections. ". Thanks! |
@jianli-wei thanks for confirming! Because that additional doc bug is associated with another BZ, I have removed that text in a separate PR for tracking purposes: #37245 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherrypick enterprise-4.9 |
/cherrypick enterprise-4.8 |
/cherrypick enterprise-4.7 |
/cherrypick enterprise-4.6 |
@codyhoag: #37150 failed to apply on top of branch "enterprise-4.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@codyhoag: new pull request created: #37249 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@codyhoag: #37150 failed to apply on top of branch "enterprise-4.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@codyhoag: #37150 failed to apply on top of branch "enterprise-4.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://bugzilla.redhat.com/show_bug.cgi?id=1948730
Added the Configuring the cluster-wide proxy during installation module into various (mostly IPI) assemblies, since it's now supported using the installer. Also removed an incorrect note in Configuring the cluster-wide proxy, which stated that UPI was the only supported install type for cluster-wide proxy.