Skip to content

Conversation

@xenolinux
Copy link
Contributor

@xenolinux xenolinux commented Oct 14, 2021

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2021
@netlify
Copy link

netlify bot commented Oct 14, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: def1582

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6168563471b4910008e5eded

😎 Browse the preview: https://deploy-preview-37535--osdocs.netlify.app

@xenolinux xenolinux changed the title [WIP] BZ1977949: Add the instruction to check ignition run time BZ1977949: Add the instruction to check ignition run time Oct 14, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2021
Copy link
Contributor

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tiny items; otherwise, LGTM!

@xenolinux
Copy link
Contributor Author

@mike-nguyen Kindly review

@xenolinux
Copy link
Contributor Author

Applicable for 4.6+ versions

@bobfuru
Copy link
Contributor

bobfuru commented Oct 14, 2021

LGTM!

@mike-nguyen
Copy link
Member

This feature is not currently in RHCOS so we will need to hold off on merging this until then.

@xenolinux
Copy link
Contributor Author

Closing this pull request, since this is now a feature request for RHCOS for OCP version 4.10.0

@xenolinux xenolinux closed this Oct 18, 2021
@xenolinux xenolinux deleted the bug1977949 branch December 20, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants