Skip to content

NE768: Document syslog maxLength parameter support for an Ingress Controller #41138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2022
Merged

NE768: Document syslog maxLength parameter support for an Ingress Controller #41138

merged 1 commit into from
Feb 3, 2022

Conversation

@chinmayi-chandrasekar
Copy link
Contributor

@chinmayi-chandrasekar chinmayi-chandrasekar commented Jan 28, 2022 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2022
@netlify
Copy link

netlify bot commented Jan 28, 2022 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: e270083

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61fb75d68a28420007415507

😎 Browse the preview: https://deploy-preview-41138--osdocs.netlify.app

sairameshv
sairameshv suggested changes Jan 28, 2022
View reviewed changes
modules/nw-ingress-controller-configuration-parameters.adoc Outdated
Copy link
Member

@sairameshv sairameshv Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maximum length is 1024 bytes by default.

Copy link
Contributor Author

@chinmayi-chandrasekar chinmayi-chandrasekar Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sairameshv Comment addressed.

melvinjoseph86
melvinjoseph86 reviewed Jan 28, 2022
View reviewed changes
modules/nw-ingress-controller-configuration-parameters.adoc Outdated
Copy link

@melvinjoseph86 melvinjoseph86 Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a range for syslog message length. 480-4096, you may include that also

Copy link
Contributor Author

@chinmayi-chandrasekar chinmayi-chandrasekar Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melvinjoseph86 Comment addressed.

@chinmayi-chandrasekar chinmayi-chandrasekar force-pushed the NE768_syslog_message_length branch from 6a735c6 to 7db5eb7 Compare January 28, 2022 10:08
kalexand-rh
kalexand-rh reviewed Feb 2, 2022
View reviewed changes
modules/nw-ingress-controller-configuration-parameters.adoc Outdated
Copy link
Contributor

@kalexand-rh kalexand-rh Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be more useful if you formatted the range and default values as values, like in line 142. Consider also combining the last two sentences, sort of like:

If this field is empty, the maximum length is set to the default value of `1024` bytes.

Copy link
Contributor Author

@chinmayi-chandrasekar chinmayi-chandrasekar Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalexand-rh Comment addressed.

@kalexand-rh
Copy link
Contributor

kalexand-rh commented Feb 2, 2022

On line 4, you need to add the module type:

:_content-type: REFERENCE

@kalexand-rh kalexand-rh added branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR labels Feb 2, 2022
@kalexand-rh kalexand-rh added this to the Future Release milestone Feb 2, 2022
@chinmayi-chandrasekar
Copy link
Contributor Author

chinmayi-chandrasekar commented Feb 3, 2022

:_content-type: REFERENCE

@kalexand-rh Comment addressed.

@chinmayi-chandrasekar chinmayi-chandrasekar force-pushed the NE768_syslog_message_length branch from 7db5eb7 to e270083 Compare February 3, 2022 06:27
@kalexand-rh kalexand-rh merged commit a45802d into openshift:main Feb 3, 2022
@kalexand-rh
Copy link
Contributor

kalexand-rh commented Feb 3, 2022

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 3, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 3, 2022

@kalexand-rh: new pull request created: #41330

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru bobfuru modified the milestones: Future Release, OCP 4.10 GA Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

+2 more reviewers

@melvinjoseph86 melvinjoseph86 melvinjoseph86 left review comments

@sairameshv sairameshv sairameshv requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.10 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@chinmayi-chandrasekar @kalexand-rh @openshift-cherrypick-robot @sairameshv @melvinjoseph86 @bobfuru