-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-3073: Adds RN for cluster support #41598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 620dc5b 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/621cea69f1492f00079cfa74 😎 Browse the preview: https://deploy-preview-41598--osdocs.netlify.app |
@kdoberst PTAL. Thank you! |
@yapei PTAL. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can manage subscription settings under the *Service Level Agreement(SLA)* of the *Overview* page
Shall we update it to something like
You can manage subscription settings by clicking `Manage subscription settings` link under the *Service Level Agreement(SLA)* of the *Overview* page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also currently SLA info can not be shown correctly due to bug https://bugzilla.redhat.com/show_bug.cgi?id=2048059
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a missing space between Agreement and (SLA).
Looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid we don't have Overview -> Cluster page
, are you targetting Overview -> Details card
or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yapei yes, I think so. I have updated and moved to the known issues section of the release notes.
https://bugzilla.redhat.com/show_bug.cgi?id=2048059 is a bug we should add to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps make "Currently, support level . . . " the introductory clause
I suggest dropping "via an alert" to improve clarity.
Maybe instead of "It" we can say "The incorrect status"
You can remove the parentheses and formatting around the BZ#2048059 link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we have only this line to be added for cluster support in RN, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct.
95759a3
to
fc3cdea
Compare
@yapei moved back to "new features and enhancements" section based on https://bugzilla.redhat.com/show_bug.cgi?id=2057438#c3. Is this note ready to go? |
@opayne1 thanks for your continuous updates, it looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{product-title} now allows you to easily view support level information about your cluster on the *Overview* -> *Details* card, in the *Cluster Settings*, in the *About* modal, and adds a notification to your notifications drawer when the cluster is unsupported. You can manage subscription settings under the *Service Level Agreement (SLA)* of the *Overview* page. | |
{product-title} now enables you to view support level information about your cluster on the *Overview* -> *Details* card, in the *Cluster Settings*, in the *About* modal, and adds a notification to your notifications drawer when the cluster is unsupported. You can manage subscription settings under the *Service Level Agreement (SLA)* of the *Overview* page. |
- From the IBM Style Guide on "allow"
allow verb
Avoid stating that inanimate objects grant abilities to people, as in "the product allows you to...". Whenever possible, use a direct, user-focused alternative such as "you can use the product to..." or "with this product, users can..."
- "Easy" is a subjective term, I would try to avoid it. IBM Style Guide says:
Use with caution. It is normally not accurate to say, “With IBM's service products, installation of your new POWER system will be easy.” It may be accurate to say, “IBM's service products can be used to make installation of your new POWER system easier than if you tried to manage your own installation.”
- The first sentence is really hard to follow, in my opinion. I would consider something like:
"{product-title} now enables you to view support level information about your cluster. You can add a notification to your notifications drawer when the cluster is unsupported. To add a notification, navigate to Overview -> Details card in the Cluster Settings, in the About modal. From the Overview page, you can manage subscription settings under the Service Level Agreement (SLA). "
Applies to OSDOCS-3073
enterprise-4.10
only