Skip to content

Conversation

opayne1
Copy link
Contributor

@opayne1 opayne1 commented Feb 8, 2022

Applies to OSDOCS-3073

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2022
@netlify
Copy link

netlify bot commented Feb 8, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 620dc5b

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/621cea69f1492f00079cfa74

😎 Browse the preview: https://deploy-preview-41598--osdocs.netlify.app

@opayne1
Copy link
Contributor Author

opayne1 commented Feb 14, 2022

@kdoberst PTAL. Thank you!

@opayne1
Copy link
Contributor Author

opayne1 commented Feb 16, 2022

@yapei PTAL. Thank you!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an alert on the *Overview* -> *Cluster* page , we show SLA info in Home -> Overview -> Details card
in the *Cluster Settings*, shall we use in Cluste Settings page or on Cluster Settings page ?
attaching a screenshot for reference
Screen Shot 2022-02-17 at 3 31 57 PM

Copy link

@yapei yapei Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can manage subscription settings under the *Service Level Agreement(SLA)* of the *Overview* page

Shall we update it to something like

You can manage subscription settings by clicking `Manage subscription settings` link under the *Service Level Agreement(SLA)* of the *Overview* page

Copy link

@yapei yapei Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also currently SLA info can not be shown correctly due to bug https://bugzilla.redhat.com/show_bug.cgi?id=2048059

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a missing space between Agreement and (SLA).

@ahardin-rh ahardin-rh added branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR labels Feb 17, 2022
@kdoberst
Copy link

Looks good to me

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2022
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid we don't have Overview -> Cluster page, are you targetting Overview -> Details card or something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yapei yes, I think so. I have updated and moved to the known issues section of the release notes.

@yapei
Copy link

yapei commented Feb 21, 2022

https://bugzilla.redhat.com/show_bug.cgi?id=2048059 is a bug we should add to Known issues

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2022
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2022
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps make "Currently, support level . . . " the introductory clause
I suggest dropping "via an alert" to improve clarity.
Maybe instead of "It" we can say "The incorrect status"
You can remove the parentheses and formatting around the BZ#2048059 link.

Copy link

@yapei yapei Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we have only this line to be added for cluster support in RN, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct.

@opayne1 opayne1 force-pushed the OSDOCS-3073 branch 2 times, most recently from 95759a3 to fc3cdea Compare February 25, 2022 14:55
@opayne1
Copy link
Contributor Author

opayne1 commented Feb 25, 2022

@yapei moved back to "new features and enhancements" section based on https://bugzilla.redhat.com/show_bug.cgi?id=2057438#c3. Is this note ready to go?

@yapei
Copy link

yapei commented Feb 28, 2022

@opayne1 thanks for your continuous updates, it looks good to me!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{product-title} now allows you to easily view support level information about your cluster on the *Overview* -> *Details* card, in the *Cluster Settings*, in the *About* modal, and adds a notification to your notifications drawer when the cluster is unsupported. You can manage subscription settings under the *Service Level Agreement (SLA)* of the *Overview* page.
{product-title} now enables you to view support level information about your cluster on the *Overview* -> *Details* card, in the *Cluster Settings*, in the *About* modal, and adds a notification to your notifications drawer when the cluster is unsupported. You can manage subscription settings under the *Service Level Agreement (SLA)* of the *Overview* page.
  • From the IBM Style Guide on "allow"

allow   verb
Avoid stating that inanimate objects grant abilities to people, as in "the product allows you to...". Whenever possible, use a direct, user-focused alternative such as "you can use the product to..." or "with this product, users can..."

  • "Easy" is a subjective term, I would try to avoid it. IBM Style Guide says:

Use with caution. It is normally not accurate to say, “With IBM's service products, installation of your new POWER system will be easy.” It may be accurate to say, “IBM's service products can be used to make installation of your new POWER system easier than if you tried to manage your own installation.”

  • The first sentence is really hard to follow, in my opinion. I would consider something like:

"{product-title} now enables you to view support level information about your cluster. You can add a notification to your notifications drawer when the cluster is unsupported. To add a notification, navigate to Overview -> Details card in the Cluster Settings, in the About modal. From the Overview page, you can manage subscription settings under the Service Level Agreement (SLA). "

@sagidlow sagidlow merged commit 1a6fe28 into openshift:enterprise-4.10 Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants