-
Notifications
You must be signed in to change notification settings - Fork 1.8k
MIG-1017 Document network bridge solution for air gapped customers #41620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jmontleon Please review for accuracy and completeness, and there are several questions that need answers. Also, please make sure that I correctly fixed the incomplete sentence in modules/migration-adding-cluster-to-cam.adoc. |
✅ Deploy Preview for osdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the UI, you create a MigCluster CR by adding a cluster. Here's the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I added links in the parent assembly under .Additional resources, following this module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you get it by running $ oc config view
. See docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logs for the OpenVPN pods.
oc get po
is short for oc get pods
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
= token of the migration controller service account.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A list of pods in the namespace, with their status, restarts, and age,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The video demo shows the result. Source cluster at 2:12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I added that, but I'm not sure how to refer to the string following openvpn
. I referred to is <log-hash>
. @jmontleon Can you weigh in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this as a step in the procedure.
5fdf51a
to
69bcc86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ oc logs -f <openvpn> -n <namespace> -c openvpn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
5fffee3
to
d09fc74
Compare
f81d37a
to
a67157d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is Jason's name mentioned here ? is it relevant to the customers ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this @midays - the entire bit in parenthesis should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the end of the url it's also requried to specify the port as follows:
https://proxied-cluster.${namespace}.svc.cluster.local:8443
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@midays Please review my changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source cluster needs to be added to the mtc console, not the destination.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cluster name: Source cluster name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
e272611
to
e998a20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know if you have questions. I tried to provide references to the style rules where I could find them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional resources are limited to an unordered list of links or xrefs. (See the peer review checklist
Also, this is duplicated at the end of the modules/migration-migrating-on-prem-to-cloud.adoc
file.
I think that this would work better at the end of the procedure module as a [TIP]
admonition. This is how I have most commonly seen these examples presented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it as a tip close to where I first mentioned the command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* For information on creating a MigCluster CR manifest for each remote cluster, see | |
* For information about creating a MigCluster CR manifest for each remote cluster, see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelryanpeter Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.Additional resources | |
[role="_additional-resources"] | |
.Additional resources |
Re: Jupiter guidelines from the OSDOCS peer review checklist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* For information on adding a cluster using the web console, see xref:../migrating_from_ocp_3_to_4/migrating-applications-3-4.adoc#migrating-applications-mtc-web-console_migrating-applications-3-4[Migrating your applications by using the {mtc-short} web console] | |
* For information about adding a cluster using the web console, see xref:../migrating_from_ocp_3_to_4/migrating-applications-3-4.adoc#migrating-applications-mtc-web-console_migrating-applications-3-4[Migrating your applications by using the {mtc-short} web console] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the hard wrap/line break here. It shows up inline in the preview, but we don't want to have the line break in the .adoc
.
Re: repo guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ oc get service -n _<namespace>_ | |
$ oc get service -n <namespace> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIxed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. On the source node, get the SA token for the migration controller: | |
. On the source node, get the service account (SA) token for the migration controller: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicated in the assembly file. Please see that note for a comment on replacing the example --help
command as a [TIP]
admonition in this procedure module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. Launch the {mtc-short} web console and add the source cluster, using the following values: | |
. Open the {mtc-short} web console and add the source cluster, using the following values: |
ISG recommends using start or open instead of launch unless it is part of the product terminology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example: | |
.Example command |
@michaelryanpeter Please do not merge this until the MTC 1.7 release. I don't believe there is any way to automatically indicate this, so I or someone else on the team will give the go-ahead. |
@michaelryanpeter Please merge. MTC 1.7 is now live. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.Example output | |
[source,terminal] | |
---- | |
NAME READY STATUS RESTARTS AGE | |
<pod_name> 2/2 Running 0 44s | |
[source,terminal,subs="+quotes"] | |
---- | |
# oc logs -f -n <namespace> <pod_name> -c openvpn | |
---- | |
When the address of the load balancer is resolved, the message `Initialization Sequence Completed` appears at the end of the log. | |
==== | |
.Example output | |
[source,terminal] | |
---- | |
NAME READY STATUS RESTARTS AGE | |
<pod_name> 2/2 Running 0 44s | |
---- | |
[source,terminal,subs="+quotes"] | |
---- | |
# oc logs -f -n <namespace> <pod_name> -c openvpn | |
---- | |
When the address of the load balancer is resolved, the message `Initialization Sequence Completed` appears at the end of the log. | |
==== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelryanpeter Fixed.
/cherrypick enterprise-4.10 |
/cherrypick enterprise-4.11 |
@michaelryanpeter: new pull request created: #43793 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@michaelryanpeter: new pull request created: #43794 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR addresses https://issues.redhat.com/browse/MIG-1017.
This applies to:
enterprise-4.10
Preview:
https://deploy-preview-41620--osdocs.netlify.app/openshift-enterprise/latest/migrating_from_ocp_3_to_4/advanced-migration-options-3-4.html#migration-migrating-applications-on-prem-to-cloud_advanced-migration-options-3-4
Added a new module:
modules/migration-migrating-on-prem-to-cloud.adoc
Minor fix in existing module (sentence was incomplete)