Skip to content

RHDEVDOCS-3619: Update the creating applications flow as per the latest UI changes #41972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2022
Merged

RHDEVDOCS-3619: Update the creating applications flow as per the latest UI changes #41972

merged 1 commit into from
Mar 2, 2022

Conversation

HarshCasper
Copy link
Contributor

@HarshCasper HarshCasper commented Feb 16, 2022 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 16, 2022
@netlify
Copy link

netlify bot commented Feb 16, 2022 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: bd8e38e

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/621f982b1554980008f35123

😎 Browse the preview: https://deploy-preview-41972--osdocs.netlify.app

christoph-jerolimov
christoph-jerolimov suggested changes Feb 16, 2022
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small suggestions:

christoph-jerolimov
christoph-jerolimov approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is fine 👍

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2022
rolfedh
rolfedh reviewed Feb 28, 2022
View reviewed changes
rolfedh
rolfedh reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @HarshCasper. Left some suggestions. Ping me when you need me to take another look. Thanks!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 28, 2022

New changes are detected. LGTM label has been removed.

rolfedh
rolfedh reviewed Feb 28, 2022
View reviewed changes
rolfedh
rolfedh approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @HarshCasper. Without the interface in front of me, it's unclear whether it makes sense to give the user more specific instructions on setting the non-default port number. I leave it up to you...

@rolfedh
Copy link
Contributor

rolfedh commented Feb 28, 2022

Please remember to fetch, rebase, and rebuild locally without errors before requesting merge.

Preeticp
Preeticp reviewed Mar 2, 2022
View reviewed changes
Preeticp
Preeticp reviewed Mar 2, 2022
View reviewed changes
Preeticp
Preeticp reviewed Mar 2, 2022
View reviewed changes
@Preeticp Preeticp added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.10 labels Mar 2, 2022
@Preeticp Preeticp added this to the Next Release milestone Mar 2, 2022
@Preeticp Preeticp added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2022
@Preeticp Preeticp merged commit 8fc3fec into openshift:main Mar 2, 2022
@Preeticp
Copy link
Contributor

Preeticp commented Mar 2, 2022

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 2, 2022
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #42672

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HarshCasper HarshCasper deleted the rhdevdocs-3619 branch March 2, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Preeticp Preeticp Preeticp left review comments

+2 more reviewers

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

@rolfedh rolfedh rolfedh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@christoph-jerolimov christoph-jerolimov

Labels

branch/enterprise-4.10 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

5 participants

@HarshCasper @rolfedh @Preeticp @openshift-cherrypick-robot @christoph-jerolimov