Skip to content

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Feb 25, 2022

@abrennan89 abrennan89 added the dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs label Feb 25, 2022
@abrennan89 abrennan89 added this to the Next Release milestone Feb 25, 2022
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 25, 2022
@netlify
Copy link

netlify bot commented Feb 25, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 64b7510

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/621e9257c4cb9f0008599a2e

😎 Browse the preview: https://deploy-preview-42439--osdocs.netlify.app

@gabriel-rh
Copy link
Contributor

gabriel-rh commented Mar 1, 2022

@abrennan89 the content looks good to me. The only issue I spotted is in the example command:

$ odo preference unset updatednotification

this should be "update" not "updated"

Otherwise, good to merge imo.

(I think all odo content applies to OCP 4.6+)

@abrennan89
Copy link
Contributor Author

abrennan89 commented Mar 1, 2022

this should be "update" not "updated"

@gabriel-rh this probably needs to be updated upstream then as well, just FYI 🙂 will update and merge this today, thanks!

@abrennan89 abrennan89 added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 1, 2022
@abrennan89 abrennan89 merged commit 867f375 into openshift:main Mar 1, 2022
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.6

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.7

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.8

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.9

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@abrennan89: new pull request created: #42607

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #42608

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #42609

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #42610

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #42611

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 deleted the RHDEVDOCS-3594 branch June 30, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants