Skip to content

Conversation

@mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Mar 10, 2022

@mburke5678 mburke5678 added this to the Next Release milestone Mar 10, 2022
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2022
@netlify
Copy link

netlify bot commented Mar 10, 2022

✅ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 0fa419d

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6239e29948642b00095a69eb

😎 Browse the preview: https://deploy-preview-43048--osdocs.netlify.app

@mburke5678
Copy link
Contributor Author

@jianli-wei @kwoodson PTAL

@jianli-wei
Copy link

LGTM

@mburke5678 mburke5678 force-pushed the alibana-add-ap-northeast-2-to-RN branch 2 times, most recently from 791ae54 to 926e602 Compare March 17, 2022 12:45
@xltian
Copy link

xltian commented Mar 18, 2022

Approved from QE.

Copy link

@gauravsingh85 gauravsingh85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mburke5678
Copy link
Contributor Author

@sferich888 approved in email.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mburke5678 I suggest changing 'If you would like to use...' to 'If you want to use...'. Otherwise, LGTM.

@jeana-redhat jeana-redhat added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 22, 2022
@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2022
@mburke5678 mburke5678 force-pushed the alibana-add-ap-northeast-2-to-RN branch from 9bf11cb to 926e602 Compare March 22, 2022 14:50
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2022
@mburke5678 mburke5678 force-pushed the alibana-add-ap-northeast-2-to-RN branch from 55d5c76 to 0fa419d Compare March 22, 2022 14:52
@mburke5678 mburke5678 merged commit c7f9994 into openshift:enterprise-4.10 Mar 22, 2022
@mburke5678 mburke5678 deleted the alibana-add-ap-northeast-2-to-RN branch March 22, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants