THREESCALE-7919: Added content for the DestinationRule custom resource. #46998
Conversation
openshift-ci
bot
added
needs-rebase
dfennessy
changed the title
openshift-ci
bot
removed
the
needs-rebase
dfennessy
force-pushed
the
7919-ProvideDestinationRuleServiceEntry
branch
from
04d329a to
c8ef0e3
Compare
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
|
Thanks @rahulanand16nov 😀 |
|
This PR needs a preview. The automated preview is currently disabled. The OpenShift Docs Manual has steps for how to create a manual preview here -> https://docs.google.com/document/d/1fLMpK4bqthtFlCwA36yeo2cI-pExFpX76VMnSi_In6Q/edit#heading=h.vrlifsbvvjd8 |
| .Procedure | ||
|
|
||
| * Apply the following external `ServiceEntry` custom resources to your cluster: | ||
| * Apply the following external `ServiceEntry` and related `DestinationRule` custom resources to your cluster: |
There was a problem hiding this comment.
If this is a procedure, shouldn't this be formatted as numbered steps instead of a bulleted list?
There was a problem hiding this comment.
It's a single step. Does a single step need numbering?
There was a problem hiding this comment.
Updating four different files is a single step? Unless you can do this with a single command, I'd say this is four different steps.
There was a problem hiding this comment.
Thanks @JStickler
| mode: SIMPLE | ||
| sni: multitenant.3scale.net | ||
| ---- | ||
There was a problem hiding this comment.
Line 84 - The flow here might be better if you said something like, "Use the following command to apply external ServiceEntry and related DestinationRule custom resources to your cluster." list the commands, and the after the commands list the YAML files.
Line 100 "To do this, change the location of these services in the custom resources." these services is vague, we should be clear about which services should be moved to achieve the goal here.
There was a problem hiding this comment.
Thanks @JStickler
@rahulanand16nov
Can I get clarification on the following lines regarding "these services":
Alternatively, you can deploy an in-mesh 3scale service. To do this, change the location of these services in the CRs.
There was a problem hiding this comment.
@dfennessy Here, we are using the URL for the 3scale SaaS version, but it doesn't have to be; users can deploy their 3scale and use links to that deployment.
|
I'm abandoning this PR. Please close it. I came in this morning and started working on it and faced enumerable conflicts that are wasting my time. I've cloned the repo and I'm starting again. |
@JStickler Please close this. I've created another PR to replace it with the changes except where I've questions for @rahulanand16nov I'll update the new PR tomorrow: #47204 I am also having trouble manually creating the Preview using the steps in the Google doc. I will tackle this tomorrow as well. |
|
@dfennessy You might want to ping Gabriel McGoldrick or Padraig O'Grady to ask for help with the preview builds, they're both OpenShift writers in your geo. Paul Needle also might be a good resource. |
Thanks, @JStickler I will do that. |
4 participants
Work done for Jira Issue THREESCALE-7919
Reviewers