BZ#1458660: NO_PROXY etcd IP workaround #4720
Conversation
|
@sjenning @sdodson @mburke5678 PTAL |
| 1.5, | ||
| endif::[] | ||
| the master now connects to etcd via IP address. | ||
| + |
There was a problem hiding this comment.
Would it be better if this information were in paragraph form than numbered list? Those first two sentences in Step 1 confused me a bit as they are not steps. Maybe something like:
http://pastebin.test.redhat.com/500963
There was a problem hiding this comment.
I like your ordering of the wording better, but your pastebin still shows this as a numbered item, is that intentional?
| the master now connects to etcd via IP address. | ||
| + | ||
| When configuring a cluster to use proxy settings (see | ||
| xref:advanced-install-configuring-global-proxy[Configuring Global Proxy Options]), this change causes the master to etcd connection to be proxied as |
There was a problem hiding this comment.
s/master to etcd connection/master-to-etcd connection (?)
| (link:https://bugzilla.redhat.com/show_bug.cgi?id=1466783[*BZ#1466783*]). | ||
| // end::BZ1466783-workaround-install[] | ||
|
|
||
| . Finally, run the advanced installation using the following playbook: |
There was a problem hiding this comment.
Probably don't need "Finally" here. Just "Run the advanced install..... "
(Finally, i can install the darn thing!)
| . If for any reason the installation fails, before re-running the installer, see | ||
| xref:installer-known-issues[Known Issues] to check for any specific | ||
| instructions or workarounds. | ||
|
|
There was a problem hiding this comment.
While we are in the neighborhood, this isn't really a step.....
There was a problem hiding this comment.
Yeah, it wasn't previously. There are two bits at the end of the install steps, basically "if it fails, see Known Issues" and "after it completes, verify the install." I can just keep them as non-numbered paragraphs that come after the procedure. I was entertaining making them all numbered since this section is going from a previously non-numbered single "step" to now multiple steps, if only temporarily.
There was a problem hiding this comment.
Maybe I'll join this as just a sentence at the end of the prior step....
|
@mburke5678 Updates made per comments. |
sdodson
left a comment
sdodson
left a comment
There was a problem hiding this comment.
lgtm, minor nit but fine as is
There was a problem hiding this comment.
s/master to etcd/master-to-etcd
or master/etcd connection?
There was a problem hiding this comment.
s/master to etcd/master-to-etcd
or master/etcd connection?
|
LGTM. It just feels like the "master to etcd connection" wording needs something. master-to-etcd or master/etcd. |
|
@mburke5678 @sdodson Thanks, updates made. Merging and publishing. |
3 participants
xref: https://bugzilla.redhat.com/show_bug.cgi?id=1458660
In Advanced Installation, added the workaround as a first step in the Running The Advanced Installation section, right before running
ansible-playbook:http://file.rdu.redhat.com/~adellape/070617/container-platform/3.5/install_config/install/advanced_install.html#running-the-advanced-installation
Since I couldn't figure out how to set
openshift_no_proxyusing theinstaller.cfg.ymlfor Quick Installs (since it's a cluster-wide variable and not host-specific), I just put the workaround as the first step in the Verifying the Installation section at the end, and have them manually updateNO_PROXYin thesysconfigfiles:http://file.rdu.redhat.com/~adellape/070617/container-platform/3.5/install_config/install/quick_install.html#quick-verifying-the-installation
For the two upgrade sections (Automated or Manual), I also took the
sysconfigroute at the end during Verifying the Upgrade:http://file.rdu.redhat.com/~adellape/070617/container-platform/3.5/install_config/upgrading/automated_upgrades.html#verifying-the-upgrade
http://file.rdu.redhat.com/~adellape/070617/container-platform/3.5/install_config/upgrading/manual_upgrades.html#manual-upgrades-verifying-the-upgrade