-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OADP#395: Velero plug-in configuration #47365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
457dfd3 to
fd8e5d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure all of this is suppose to be on a "procedure".
I think it's better to just specify the different plugin types as options, like in the upstream doc:
https://github.com/openshift/oadp-operator/blob/master/docs/config/plugins.md
It may cause a confusion and the steps make it look like custom plguin is dependent on default plugins existence...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mperetzred Should I include the code sample as an example, like in the upstream documentation, without making it into a procedure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add openshift plugin in the examples by default. Here and also in other modules.
1948aa2 to
697d047
Compare
3b743f9 to
ee618d4
Compare
|
@kaovilai and @mperetzred : i rewrote this as an "information" section, instead of as a procedure. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just remove this + character
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just remove this + character
|
there is some redundant |
ee618d4 to
7ac346e
Compare
|
@mperetzred -- removed extra "+" signs. |
|
@sbeskin-redhat Please review this PR. As you can see from it and the discussions in the Jira, it is a CONCEPT module, not a PROCEDURE. |
c026d6b to
3c962dd
Compare
b57b5e3 to
41a0a64
Compare
|
The enterprise-4.12 label has been added to this PR. This is because your PR targets the If the update in your PR does NOT apply to version 4.12 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
|
Merge review approved. This review is considered "crucial" for the OADP release. This pull request can be merged upon OADP GA without the need for a second merge review. |
|
/cherrypick enterprise-4.6 |
|
@mburke5678: new pull request created: #49884 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.8 |
|
/cherrypick enterprise-4.9 |
|
/cherrypick enterprise-4.10 |
|
/cherrypick enterprise-4.11 |
|
/cherrypick enterprise-4.12 |
|
@mburke5678: new pull request created: #49885 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #49886 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #49887 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #49888 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #49889 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #49890 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OADP 1.1.0, OCP 4.6+
Resolves https://issues.redhat.com/browse/OADP-395 by adding configuration procedures for Velero plug-ins.
Preview: http://file.emea.redhat.com/rhoch/velero_plugin_congig/backup_and_restore/application_backup_and_restore/oadp-features-plugins.html#oadp-configuring-velero-plugins_oadp-features-plugins