-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OADP-377: Update IAM policy for image uploads #47386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s3:ListMultipartUploadParts apprears on line 92.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, I my bad, 2 different things, please ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mperetzred No problem -- better safe than sorry.
|
lgtm |
|
@sbeskin-redhat: Please review. |
| "s3:ListBucketMultipartUploads" | ||
| ], | ||
| "Resource": [ | ||
| "arn:aws:s3:::${BUCKET}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RichardHoch
Looks OK
lpettyjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
The enterprise-4.12 label has been added to this PR. This is because your PR targets the If the update in your PR does NOT apply to version 4.12 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
|
/cherrypick enterprise-4.6 |
|
@mburke5678: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.6 from head openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.6 and openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.6"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.7 |
|
@mburke5678: new pull request created: #49912 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.8 |
|
/cherrypick enterprise-4.9 |
|
/cherrypick enterprise-4.10 |
|
/cherrypick enterprise-4.11 |
|
/cherrypick enterprise-4.12 |
|
@mburke5678: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.8 from head openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.8 and openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.8"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #49913 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #49914 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #49915 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #49916 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.6 |
|
@mburke5678: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.6 from head openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.6 and openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.6"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The parameters added by this PR were removed in January. Except in 4.6 and 4.8. Those CPs had errors, but no one went back to fix those CPs. |
|
/cherrypick enterprise-4.6 |
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.8 |
|
@EricPonvelle: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.6 from head openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.6 and openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.6"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@EricPonvelle: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.7 from head openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.7: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.7 and openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.7"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@EricPonvelle: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.8 from head openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.8 and openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.8"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OADP 1.1.0, OCP 4.6+
Resolves https://issues.redhat.com/browse/OADP-377 by adding two IAM permissions missing from current documentation.
Preview: http://file.emea.redhat.com/rhoch/update_iam/backup_and_restore/application_backup_and_restore/installing/installing-oadp-aws.html#migration-configuring-aws-s3_installing-oadp-aws , step 5.