Skip to content

Conversation

@RichardHoch
Copy link
Contributor

@RichardHoch RichardHoch commented Jul 4, 2022

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2022
@RichardHoch RichardHoch marked this pull request as ready for review July 4, 2022 13:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2022
@RichardHoch RichardHoch changed the title OADP=377_Update IAM policy for image uploads OADP-377_Update IAM policy for image uploads Jul 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s3:ListMultipartUploadParts apprears on line 92.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I my bad, 2 different things, please ignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mperetzred No problem -- better safe than sorry.

@mperetzred
Copy link

lgtm

@RichardHoch
Copy link
Contributor Author

@sbeskin-redhat: Please review.

"s3:ListBucketMultipartUploads"
],
"Resource": [
"arn:aws:s3:::${BUCKET}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichardHoch
Looks OK

@RichardHoch RichardHoch changed the title OADP-377_Update IAM policy for image uploads OADP-377: Update IAM policy for image uploads Jul 11, 2022
@lpettyjo lpettyjo self-requested a review July 11, 2022 13:16
@lpettyjo lpettyjo added this to the Next Release milestone Jul 11, 2022
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 11, 2022
@bergerhoffer
Copy link
Contributor

The enterprise-4.12 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.11. And any PR going into main must also target the latest version branch (enterprise-4.12).

If the update in your PR does NOT apply to version 4.12 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@mburke5678: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.6 from head openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.6 and openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.6"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.7

@openshift-cherrypick-robot

@mburke5678: new pull request created: #49912

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.8

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.9

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.10

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.11

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@mburke5678: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.8 from head openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.8 and openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.8"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #49913

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #49914

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #49915

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #49916

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@mburke5678: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.6 from head openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.6 and openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.6"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

The parameters added by this PR were removed in January. Except in 4.6 and 4.8. Those CPs had errors, but no one went back to fix those CPs.

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.6

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.7

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@EricPonvelle: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.6 from head openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.6 and openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.6"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.7 from head openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.7: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.7 and openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.7"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.8 from head openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.8 and openshift-cherrypick-robot:cherry-pick-47386-to-enterprise-4.8"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants