-
Notifications
You must be signed in to change notification settings - Fork 1.8k
BZ2102828: Cu requires guidance on windows container Vs OCP windows node version compatibility and best dev practices to avoid compatibility issues. #49446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
modules/windows-pod-placement.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the original BZ there is a suggestion to point to the official Microsoft docs for more information:
Can I request that this be treated as a doc BZ and update our doc (below) to clarify that the container base image must match the windows version running on the OCP node and that the build number must match and as an additional data refer to Microsoft docs.
https://docs.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/version-compatibility
, maybe you could add a reference to it in case more information is expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modules/windows-pod-placement.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEER REVIEW: The only change in this paragraph ^^ is the removal of a comma in the first line. No other changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's beyond the scope of this PR since you just added a comma, but should we say ". . . by using a RuntimeClass
object." in the first mention?
df0675f
to
9328d51
Compare
🤖 Bots are busy building the preview. It will be available soon at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/806 |
modules/windows-pod-placement.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's beyond the scope of this PR since you just added a comma, but should we say ". . . by using a RuntimeClass
object." in the first mention?
modules/windows-pod-placement.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can "need to" be swapped to "must" ?
Based on IBMSG: https://www.ibm.com/docs/en/ibm-style?topic=word-usage#need-to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevsmit Thanks! I caught that last-minute but neglected to push the change. Thank you for confirming the correction.
@mburke5678 PTAL. |
9328d51
to
826018f
Compare
… compatibility and best dev practices to avoid compatibility issues.
826018f
to
5519756
Compare
Closing in favor of #50876 |
https://bugzilla.redhat.com/show_bug.cgi?id=2102828
Preview: Windows pod placement: Important note