Skip to content

Conversation

mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Aug 22, 2022

@mburke5678 mburke5678 added this to the Continuous Release milestone Aug 22, 2022
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 22, 2022
@mburke5678 mburke5678 changed the title Cu requires guidance on windows container Vs OCP windows node version compatibility and best dev practices to avoid compatibility issues. BZ2102828: Cu requires guidance on windows container Vs OCP windows node version compatibility and best dev practices to avoid compatibility issues. Aug 29, 2022
@mburke5678
Copy link
Contributor Author

@rrasouli @jfrancoa PTAL

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original BZ there is a suggestion to point to the official Microsoft docs for more information:

Can I request that this be treated as a doc BZ and update our doc (below) to clarify that the container base image must match the windows version running on the OCP node and that the build number must match and as an additional data refer to Microsoft docs.

https://docs.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/version-compatibility
, maybe you could add a reference to it in case more information is expected.

Copy link
Contributor Author

@mburke5678 mburke5678 Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@mburke5678 mburke5678 Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEER REVIEW: The only change in this paragraph ^^ is the removal of a comma in the first line. No other changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's beyond the scope of this PR since you just added a comma, but should we say ". . . by using a RuntimeClass object." in the first mention?

@ocpdocs-previewbot
Copy link

🤖 Bots are busy building the preview. It will be available soon at:
https://49446--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/806

@mburke5678 mburke5678 added peer-review-needed Signifies that the peer review team needs to review this PR qe-approved Signifies that QE has signed off on this PR labels Sep 26, 2022
@stevsmit stevsmit added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 26, 2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's beyond the scope of this PR since you just added a comma, but should we say ". . . by using a RuntimeClass object." in the first mention?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can "need to" be swapped to "must" ?

Based on IBMSG: https://www.ibm.com/docs/en/ibm-style?topic=word-usage#need-to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevsmit Thanks! I caught that last-minute but neglected to push the change. Thank you for confirming the correction.

@stevsmit
Copy link
Member

@mburke5678 PTAL.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2022
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2022
… compatibility and best dev practices to avoid compatibility issues.
@mburke5678
Copy link
Contributor Author

Closing in favor of #50876

@mburke5678 mburke5678 closed this Sep 26, 2022
@mburke5678 mburke5678 deleted the BZ-2102828 branch September 26, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 peer-review-in-progress Signifies that the peer review team is reviewing this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants