Skip to content

Conversation

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 4, 2022
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 4, 2022

🤖 Updated build preview is available at:
https://51192--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/1749

Copy link
Contributor

@Preeticp Preeticp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left some minor suggestions, PTAL.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the --details flag.

@gabriel-rh gabriel-rh force-pushed the RHDEVDOCS-4476keyfeatures branch from e82d6b1 to cdd7ee9 Compare October 13, 2022 10:30
@Preeticp Preeticp added branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 lgtm Indicates that a PR is ready to be merged. dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Oct 13, 2022
@Preeticp Preeticp added this to the Continuous Release milestone Oct 13, 2022
@Preeticp
Copy link
Contributor

/lgtm

Copy link

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are already using 'v2' and 'v3' in the migration doc, it would be nice if you can use the same in this doc instead of 'version 2' and 'version 3'.


== odo dev

The `odo dev` command allows you to code, build, run, debug, and test your applications on the cluster in a continuous workflow. It combines the `odo push` and `odo watch` commands from `odo` version 2 into a single command.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `odo dev` command allows you to code, build, run, debug, and test your applications on the cluster in a continuous workflow. It combines the `odo push` and `odo watch` commands from `odo` version 2 into a single command.
The `odo dev` command allows you to code, build, run, debug, and test your applications on the cluster in a continuous workflow. It combines the `odo push` and `odo watch` commands from `odo` v2 into a single command.

Comment on lines +39 to +42
Work without a running application:: Compared to version 2, the `odo add binding` command does not require the application to be running on the cluster, making it even faster.

Only supports bindable Operators::
The version 2 `odo link` command links an application to another application and any Operator-backed service. However, `odo` version 3 currently only supports connecting to services backed by Operators that are considered bindable by the Service Binding Operator.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Work without a running application:: Compared to version 2, the `odo add binding` command does not require the application to be running on the cluster, making it even faster.
Only supports bindable Operators::
The version 2 `odo link` command links an application to another application and any Operator-backed service. However, `odo` version 3 currently only supports connecting to services backed by Operators that are considered bindable by the Service Binding Operator.
Work without a running application:: Compared to v2, the `odo add binding` command does not require the application to be running on the cluster, making it even faster.
Only supports bindable Operators::
The `odo link` command of v2 links an application to another application and any Operator-backed service. However, `odo` v3 currently only supports connecting to services backed by Operators that are considered bindable by the Service Binding Operator.

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.13 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.12. And any PR going into main must also target the latest version branch (enterprise-4.13).

If the update in your PR does NOT apply to version 4.13 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2023
@kalexand-rh
Copy link
Contributor

Only versions 4.10+ are still in maintenance. I am removing labels from earlier versions from this PR.

@kalexand-rh
Copy link
Contributor

The branch/enterprise-4.14 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.13. And any PR going into main must also target the latest version branch (enterprise-4.14).

If the update in your PR does NOT apply to version 4.14 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 16, 2023
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jul 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 16, 2023

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants