Skip to content

OSDOCS-4148: Release note for "Support kubernetes-nmstate on vSphere platforms" #51249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2022
Merged

OSDOCS-4148: Release note for "Support kubernetes-nmstate on vSphere platforms" #51249

merged 1 commit into from
Oct 18, 2022

Conversation

ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Oct 4, 2022 •
edited
Loading

A release note for 4.12, Networking, supporting k8s-nmstate on VMWare vSphere

Issue: OSDOCS-4148

Version(s):

  • PR applies to: 4.12 only

Link to docs preview:
https://51249--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-12-release-notes.html#ocp-4-12-networking

Doc change:
#51746

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 4, 2022
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 4, 2022 •
edited
Loading

🤖 Updated build preview is available at:
https://51249--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/1914

@ShaunaDiaz
Copy link
Contributor Author

@creydr and @qiowang721 Please review release note and either approve or suggest revisions. Thank you!

@creydr
Copy link
Member

creydr commented Oct 5, 2022

Works for me. But we need to wait on the network manager fix and then the confirmation from QE

@ShaunaDiaz
Copy link
Contributor Author

@creydr Great, please add lgtm

@qiowang721
Copy link

works for me.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@creydr
Copy link
Member

creydr commented Oct 17, 2022 •
edited
Loading

@ShaunaDiaz will you update https://docs.openshift.com/container-platform/4.11/networking/k8s_nmstate/k8s-nmstate-about-the-k8s-nmstate-operator.html too, that vSphere is supported?

openshift-docs/networking/k8s_nmstate/k8s-nmstate-about-the-k8s-nmstate-operator.adoc

Line 14 in 6a33d83

Red Hat supports the Kubernetes NMState Operator in production environments on bare-metal, IBM Power, IBM Z, and LinuxONE installations.

@ShaunaDiaz ShaunaDiaz mentioned this pull request Oct 17, 2022
Merged
@ShaunaDiaz
Copy link
Contributor Author

@creydr Yes, Travis building it now. When it's ready, I will @ you.

creydr
creydr approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ShaunaDiaz ShaunaDiaz changed the title [WIP] [OSDOCS-4148]: Release note for "Support kubernetes-nmstate on vSphere platforms" [OSDOCS-4148]: Release note for "Support kubernetes-nmstate on vSphere platforms" Oct 17, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2022
@ShaunaDiaz
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 17, 2022
tmalove
tmalove reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@tmalove tmalove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 17, 2022
tmalove
tmalove reviewed Oct 17, 2022
View reviewed changes
tmalove
tmalove reviewed Oct 17, 2022
View reviewed changes
tmalove
tmalove reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@tmalove tmalove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 17, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@ShaunaDiaz
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 17, 2022
@jboxman-rh jboxman-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 18, 2022
creydr
creydr reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2022
@ShaunaDiaz
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 18, 2022
@jboxman-rh jboxman-rh added branch/enterprise-4.12 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 18, 2022
@jboxman-rh jboxman-rh added this to the Planned for 4.12 GA milestone Oct 18, 2022
@jboxman-rh jboxman-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 18, 2022
@jboxman-rh jboxman-rh merged commit 8a1d488 into openshift:enterprise-4.12 Oct 18, 2022
@jboxman-rh jboxman-rh changed the title [OSDOCS-4148]: Release note for "Support kubernetes-nmstate on vSphere platforms" OSDOCS-4148: Release note for "Support kubernetes-nmstate on vSphere platforms" Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@creydr creydr creydr approved these changes

@tmalove tmalove tmalove left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@creydr creydr

@qiowang721 qiowang721

Labels

branch/enterprise-4.12 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.12 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@ShaunaDiaz @ocpdocs-previewbot @creydr @qiowang721 @tmalove @jboxman-rh