RHDEVDOCS-4310 - clarify confusing statements about custom Prometheus support #51404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/S
bburt-rh
force-pushed
the
RHDEVDOCS-4310-clarify-contradictory-guidance-in-autoscaling-topic
branch
from
cd75218 to
82e1331
Compare
modules/monitoring-exposing-custom-application-metrics-for-horizontal-pod-autoscaling.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
force-pushed
the
RHDEVDOCS-4310-clarify-contradictory-guidance-in-autoscaling-topic
branch
from
82e1331 to
ea08902
Compare
|
@juzhao PTAL this PR and provide feedback and suggestions. Thank you! |
gabriel-rh
reviewed
Oct 12, 2022
modules/monitoring-exposing-custom-application-metrics-for-horizontal-pod-autoscaling.adoc
Outdated
Show resolved
Hide resolved
modules/monitoring-exposing-custom-application-metrics-for-horizontal-pod-autoscaling.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
force-pushed
the
RHDEVDOCS-4310-clarify-contradictory-guidance-in-autoscaling-topic
branch
from
ea08902 to
e915a91
Compare
bburt-rh
force-pushed
the
RHDEVDOCS-4310-clarify-contradictory-guidance-in-autoscaling-topic
branch
from
e915a91 to
52f928a
Compare
juzhao
reviewed
Oct 13, 2022
|
/lgtm |
bburt-rh
added
peer-review-done
|
/cherry-pick enterprise-4.6 |
|
@bburt-rh: new pull request created: #51696 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bburt-rh
deleted the
RHDEVDOCS-4310-clarify-contradictory-guidance-in-autoscaling-topic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: