-
Notifications
You must be signed in to change notification settings - Fork 1.8k
SPLAT-898: day 2 configuration of multiple falure domains #54788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc: @JoelSpeed @gnufied @jcpowermac This is a procedure that attempts to document the migration of a non-failure domain aware cluster to one that is aware. Any feedback you might have would be greatly appreciated. |
🤖 Build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/7252 |
cc @duanwei33 |
|
||
[IMPORTANT] | ||
==== | ||
Once a failure domain has been created it must not be deleted or modified. However, new failure domains can be appended to the list of failure domains. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan to enumerate the things you must do before doing this? Would it help the end user to understand if we had a list of, here's what would break/here's what you'd need to do if you really wanted to remove one?
Statements like this always seem weird to me when they don't have justifications for why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Joel. @gnufied would you mind providing a quick summary of the 'why' and I can incorporate it in to the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but some follow up questions. Is this storage only item? Say for example - if adding a failure-domain results in creation of VMs in that failure-domain , will removal of failure-domain result in deletion of VMs in that failure-domain? (i.e will get implemented?).
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
4.13
Issue:
https://issues.redhat.com/browse/SPLAT-898
Link to docs preview: https://54788--docspreview.netlify.app/openshift-enterprise/latest/post_installation_configuration/vsphere-failure-domain-configuration.html
QE review:
Additional information: