Skip to content

Conversation

rohennes
Copy link
Contributor

@rohennes rohennes commented Feb 6, 2023

TELCODOCS 941: Need to mirror default Ironic agent image for spoke cluster deployment using OCP 4.11 or less.

Version(s):
Peer review only please

Issue:
https://issues.redhat.com/browse/TELCODOCS-941

Link to docs preview:
https://55610--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-12-release-notes.html#ocp-4-12-0-ironic-agent-image-ztp

QE review:

  • QE has approved this change.

Additional information:
This is for RHACM 2.7 release. The merging/organization of the RHACM 2.7 RNs is handled by https://issues.redhat.com/browse/TELCODOCS-930. I just need a peer review of the RN text, then I can add the approved text in a RN Jira field. Another writer will handle merging all the RHACM 2.7 RNs to the correct location, thanks.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 6, 2023
@rohennes
Copy link
Contributor Author

rohennes commented Feb 6, 2023

/label telco
/label peer-review-needed

@openshift-ci openshift-ci bot added telco Label for all Telco PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 6, 2023
@jeana-redhat jeana-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 6, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 6, 2023

🤖 Updated build preview is available at:
https://55610--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/8382

Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about the placement of this content within the release notes.

If I am following, this is a known issue for versions prior to 4.12, but this is being added to the 4.12 RNs. Should it be a known issue in the earlier docs that is resolved with 4.12 GA? If so, it still should not be in the [id="ocp-4-12-0-ga"] section (should be up above in the main 4.12 Rel Notes).

If you aren't sure where it belongs, the rel notes team can help (@docs-rel-notes in Slack)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* AMD64 Ironic agent image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:d3f1d4d3cd5fbcf1b9249dd71d01be4b901d337fdc5f8f66569eb71df4d9d446
* AMD64 Ironic agent image: `quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:d3f1d4d3cd5fbcf1b9249dd71d01be4b901d337fdc5f8f66569eb71df4d9d446`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about AArch64, just basing that on the other PR of yours I saw today :)

Suggested change
* Aarch64 Ironic agent image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:cb0edf19fffc17f542a7efae76939b1e9757dc75782d4727fb0aa77ed5809b43
* AArch64 Ironic agent image: `quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:cb0edf19fffc17f542a7efae76939b1e9757dc75782d4727fb0aa77ed5809b43`

@jeana-redhat jeana-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 6, 2023
@rohennes
Copy link
Contributor Author

rohennes commented Feb 7, 2023

SME (Nick Carboni) and QE (Chad Crum) approved RN text. Closing as the merge will happen in another PR.

@rohennes rohennes closed this Feb 7, 2023
@JoeAldinger
Copy link
Contributor

Hi @rohennes can you please be sure that this PR is tagged in the one that is reviewed for merge so that we can make sure the doc placement is correct. I see your note above about placement being coordinated later. Let me know if I can help. cc @jeana-redhat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files. telco Label for all Telco PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants