Skip to content

[OSDOCS-5013]: GCP CPMS support (rel notes) #56750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

[OSDOCS-5013]: GCP CPMS support (rel notes) #56750

merged 1 commit into from
Mar 13, 2023

Conversation

jeana-redhat
Copy link
Contributor

@jeana-redhat jeana-redhat commented Mar 2, 2023 •
edited
Loading

Version(s):
4.13

Issue:
OCPCLOUD-1774 | OSDOCS-5013

Link to docs preview:
Additional platform support for control plane machine sets

QE review:

  • QE has approved this change.

Additional information:

@jeana-redhat jeana-redhat added this to the Planned for 4.13 GA milestone Mar 2, 2023
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 2, 2023
@jeana-redhat jeana-redhat mentioned this pull request Mar 2, 2023
Merged
1 task
@jeana-redhat jeana-redhat force-pushed the OSDOCS-5013-RN-CPMS-GCP branch from d72d6f3 to d46d755 Compare March 9, 2023 21:55
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 9, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://56750--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/10848

@jeana-redhat jeana-redhat force-pushed the OSDOCS-5013-RN-CPMS-GCP branch from d46d755 to a5d0949 Compare March 10, 2023 16:36
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2023
@jeana-redhat jeana-redhat force-pushed the OSDOCS-5013-RN-CPMS-GCP branch from a5d0949 to d8b553a Compare March 10, 2023 16:37
@jeana-redhat
Copy link
Contributor Author

This is a pretty straightforward RN addition, just adds a new bullet on line 163 (the rest of the diff is GitHub parsing the format change). Requesting all reviews at once.

@odvarkadaniel @miyadav PTAL 🙏

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 10, 2023
@mjpytlak mjpytlak added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 10, 2023
mjpytlak
mjpytlak reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@mjpytlak mjpytlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer review LGTM @jeana-redhat

@mjpytlak mjpytlak added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 10, 2023
@odvarkadaniel
Copy link

LGTM!

@miyadav
Copy link
Member

miyadav commented Mar 13, 2023

LGTM , thanks

@jeana-redhat jeana-redhat merged commit ef39d59 into openshift:enterprise-4.13 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mjpytlak mjpytlak mjpytlak left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

4.13 GA

Development

Successfully merging this pull request may close these issues.

5 participants

@jeana-redhat @ocpdocs-previewbot @odvarkadaniel @miyadav @mjpytlak