Skip to content

Add note to 'Scheduling Backup' section to set backup every 10 minutes #59713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add note to 'Scheduling Backup' section to set backup every 10 minutes #59713

merged 1 commit into from
Dec 19, 2023

Conversation

HagayVider1
Copy link
Contributor

@HagayVider1 HagayVider1 commented May 9, 2023 •
edited
Loading

GH# :
OCPBUGS# : OADP-1367
OSDOCS# : OADP-1367

Added note to 'schedule:' cron for scheduling backups every 10 minutes.

Version(s): OADP 1.2.0

Issue: https://issues.redhat.com/browse/OADP-1367

Version(s):

Enterprise 4.11 → branch/enterprise-4.11
Enterprise 4.12 → branch/enterprise-4.12
Enterprise 4.13 → branch/enterprise-4.13
Enterprise 4.14 → branch/enterprise-4.14
Enterprise 4.15 → branch/enterprise-4.15

Issue: OADP-1367

Link to docs preview:
https://59713--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/backing_up_and_restoring/oadp-scheduling-backups-doc

QE review:

  • QE has approved this change.

David Vanunu has approved this.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 9, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 9, 2023 •
edited
Loading

🤖 Mon Dec 18 00:08:55 - Prow CI generated the docs preview: https://59713--ocpdocs-pr.netlify.app

@anarnold97
Copy link
Contributor

@HagayVider1 please can you add the necessary labels to move this to OCP review
Thanks

@HagayVider1
Copy link
Contributor Author

Added link to doc preview.

@HagayVider1
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci
Copy link

openshift-ci bot commented Jun 27, 2023

@HagayVider1: Can not set label peer-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

/label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HagayVider1
Copy link
Contributor Author

/label oadp
/label peer-review-needed

@openshift-ci openshift-ci bot added OADP Label for all OADP PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 21, 2023
@snarayan-redhat snarayan-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Aug 21, 2023
snarayan-redhat
snarayan-redhat reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of suggestions. Otherwise looks good.

@snarayan-redhat snarayan-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 21, 2023
@kalexand-rh
Copy link
Contributor

I've opened the enterprise-4.15 branch. Please review your PR and update the applicable versions to also cover 4.15 if you expect that the changes in this PR will be valid in that branch.

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 7, 2023
@HagayVider1
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 7, 2023
@anarnold97
Copy link
Contributor

@HagayVider1 - Please do not ask for this to be merged

@abhatt-rh
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 8, 2023
@abhatt-rh
Copy link
Contributor

abhatt-rh commented Dec 8, 2023 •
edited
Loading

@HagayVider1 Kindly provide an updated preview link, squash your commits, and then re-tag for merge. Removing the merge-related labels for now.

/remove-label merge-review-needed
/remove-label merge-review-in-progress

@openshift-ci openshift-ci bot removed merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Dec 8, 2023
@HagayVider1 HagayVider1 force-pushed the oadp-1367_schedule-backup-10min_hvider branch from 705bfc5 to 8d8fa59 Compare December 10, 2023 15:22
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2023
@HagayVider1 HagayVider1 force-pushed the oadp-1367_schedule-backup-10min_hvider branch from 962bd0c to 50c18b5 Compare December 18, 2023 00:04
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 18, 2023

@HagayVider1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@HagayVider1
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 19, 2023
emarcusRH
emarcusRH approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@emarcusRH emarcusRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 19, 2023
@mburke5678 mburke5678 merged commit 4571559 into openshift:main Dec 19, 2023
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.11

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.12

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.13

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.14

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link

@mburke5678: #59713 failed to apply on top of branch "enterprise-4.11":

Applying: Add note to 'Scheduling Backup' section to set backup every 10 minutes
Using index info to reconstruct a base tree...
M	backup_and_restore/application_backup_and_restore/backing_up_and_restoring/oadp-scheduling-backups-doc.adoc
M	virt/backup_restore/virt-backing-up-vms.adoc
Falling back to patching base and 3-way merge...
Auto-merging virt/backup_restore/virt-backing-up-vms.adoc
Removing modules/oadp-scheduling-backups.adoc
Auto-merging backup_and_restore/application_backup_and_restore/backing_up_and_restoring/oadp-scheduling-backups-doc.adoc
CONFLICT (content): Merge conflict in backup_and_restore/application_backup_and_restore/backing_up_and_restoring/oadp-scheduling-backups-doc.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add note to 'Scheduling Backup' section to set backup every 10 minutes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #69609

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Dec 19, 2023
Closed
Closed
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #69610

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 19, 2023
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #69611

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #69612

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 19, 2023
Merged
This was referenced Jan 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snarayan-redhat snarayan-redhat snarayan-redhat left review comments

+2 more reviewers

@adellape adellape adellape left review comments

@emarcusRH emarcusRH emarcusRH approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adellape adellape

@emarcusRH emarcusRH

Labels

branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 lgtm Indicates that a PR is ready to be merged. OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.