Skip to content

RHDEVDOCS-5245: Performance Tuning for Openshift Pipelines #60648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2023
Merged

RHDEVDOCS-5245: Performance Tuning for Openshift Pipelines #60648

merged 1 commit into from
Jun 16, 2023

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented May 29, 2023 •
edited
Loading

• Aligned team: Dev Tools
• OCP version for cherry-picking: enterprise-4.12 and later
• JIRA issue: RHDEVDOCS-5245
• Preview page: Performance tuning using TektonConfig CR
• SME Review: Completed by @jkandasa
• QE review: Completed by @ppitonak
• Peer-review: Completed by @mramendi

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 29, 2023 •
edited by openshift-ci bot
Loading

@ekristova: This pull request references RHDEVDOCS-5245 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking:
• JIRA issue: RHDEVDOCS-5245
• Preview page:
• SME Review: @
• QE review: @
• Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 29, 2023
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 29, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://60648--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/17657

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 29, 2023 •
edited by openshift-ci bot
Loading

@ekristova: This pull request references RHDEVDOCS-5245 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking:
• JIRA issue: RHDEVDOCS-5245
• Preview page: Performance tuning using TektonConfig CR
• SME Review: @
• QE review: @
• Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 29, 2023 •
edited by openshift-ci bot
Loading

@ekristova: This pull request references RHDEVDOCS-5245 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: TBD before merge
• JIRA issue: RHDEVDOCS-5245
• Preview page: Performance tuning using TektonConfig CR
• SME Review: @jkandasa
• QE review: @ppitonak
• Peer-review: @mramendi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eromanova97
Copy link
Contributor Author

Hello @jkandasa @ppitonak PTAL at this PR and provide feedback. Thank you!

mramendi
mramendi reviewed May 30, 2023
View reviewed changes
jkandasa
jkandasa reviewed May 31, 2023
View reviewed changes
@eromanova97 eromanova97 force-pushed the RHDEVDOCS-5245 branch 2 times, most recently from 2cdbfcf to e9ead28 Compare May 31, 2023 09:51
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2023 •
edited by openshift-ci bot
Loading

@ekristova: This pull request references RHDEVDOCS-5245 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: TBD before merge
• JIRA issue: RHDEVDOCS-5245
• Preview page: Performance tuning using TektonConfig CR
• SME Review: @jkandasa
• QE review: Completed by @ppitonak
• Peer-review: @mramendi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jkandasa
jkandasa approved these changes Jun 1, 2023
View reviewed changes
Copy link

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2023 •
edited by openshift-ci bot
Loading

@ekristova: This pull request references RHDEVDOCS-5245 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: TBD before merge
• JIRA issue: RHDEVDOCS-5245
• Preview page: Performance tuning using TektonConfig CR
• SME Review: Completed by @jkandasa
• QE review: Completed by @ppitonak
• Peer-review: @mramendi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mramendi
mramendi reviewed Jun 1, 2023
View reviewed changes
mramendi
mramendi reviewed Jun 1, 2023
View reviewed changes
mramendi
mramendi reviewed Jun 6, 2023
View reviewed changes
@eromanova97 eromanova97 force-pushed the RHDEVDOCS-5245 branch 2 times, most recently from 2f65937 to bf112e9 Compare June 7, 2023 09:42
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 7, 2023 •
edited by openshift-ci bot
Loading

@ekristova: This pull request references RHDEVDOCS-5245 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: TBD before merge
• JIRA issue: RHDEVDOCS-5245
• Preview page: Performance tuning using TektonConfig CR
• SME Review: Completed by @jkandasa
• QE review: Completed by @ppitonak
• Peer-review: Completed by @mramendi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mramendi
mramendi reviewed Jun 7, 2023
View reviewed changes
@mramendi
Copy link
Contributor

mramendi commented Jun 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@eromanova97 eromanova97 changed the title [WIP] RHDEVDOCS-5245: Performance Tuning for Openshift Pipelines RHDEVDOCS-5245: Performance Tuning for Openshift Pipelines Jun 16, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2023
bburt-rh
bburt-rh reviewed Jun 16, 2023
View reviewed changes
modules/op-performance-tuning-using-tektonconfig-cr.adoc

| `disable-ha` | Enable or disable the high availability (HA) support. By default, the HA support is enabled. | `false`

| `buckets` | The number of buckets used to partition key space of each reconciler.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `buckets` | The number of buckets used to partition key space of each reconciler.
| `buckets` | The number of buckets used to partition the key space for each reconciler.
  • add definite article
  • 'for' is more idiomatic here

bburt-rh
bburt-rh reviewed Jun 16, 2023
View reviewed changes
modules/op-performance-tuning-using-tektonconfig-cr.adoc

| `buckets` | The number of buckets used to partition key space of each reconciler.

Each of the replicas uses these buckets. The instance that owns a bucket handles the reconciling of the keys partitioned into that bucket. The maximum value is `10` | `1`
Copy link
Contributor

@bburt-rh bburt-rh Jun 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Each of the replicas uses these buckets. The instance that owns a bucket handles the reconciling of the keys partitioned into that bucket. The maximum value is `10` | `1`
Each of the replicas uses these buckets. The instance that owns a bucket reconciles the keys partitioned into that bucket. The maximum value is `10` | `1`
  • fix awkward and wordy noun-based phrasing reconciling of

bburt-rh
bburt-rh reviewed Jun 16, 2023
View reviewed changes
modules/op-performance-tuning-using-tektonconfig-cr.adoc

Each of the replicas uses these buckets. The instance that owns a bucket handles the reconciling of the keys partitioned into that bucket. The maximum value is `10` | `1`

| `threads-per-controller` | The number of threads (workers) to use when the workqueue of the {pipelines-shortname} controller is processed. | `2`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should workqueue be work queue? If workqueue isn't the name of a technical feature, it should be two words.

bburt-rh
bburt-rh reviewed Jun 16, 2023
View reviewed changes
modules/op-performance-tuning-using-tektonconfig-cr.adoc

| `kube-api-qps` | The maximum queries per second (QPS) to the cluster master from the REST client. | `5.0`

| `kube-api-burst` | The maximum burst for throttle. | `10`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `kube-api-burst` | The maximum burst for throttle. | `10`
| `kube-api-burst` | The maximum burst for a throttle. | `10`

bburt-rh
bburt-rh reviewed Jun 16, 2023
View reviewed changes
modules/op-performance-tuning-using-tektonconfig-cr.adoc

You can modify the fields under the `.spec.pipeline.performance` parameter in the `TektonConfig` custom resource (CR) to change high availability (HA) support and performance configuration for the {pipelines-shortname} controller.

.Example: `TektonConfig` performance fields
Copy link
Contributor

@bburt-rh bburt-rh Jun 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.Example: `TektonConfig` performance fields
.Example TektonConfig performance fields

@shipsing
Copy link
Contributor

Cherry-pick the content to enterprise 4.12, 4.13, and 4.14

@bburt-rh bburt-rh merged commit ecbf360 into openshift:main Jun 16, 2023
@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.13

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #61379

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 16, 2023
Merged
@bburt-rh bburt-rh added peer-review-done Signifies that the peer review team has reviewed this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs qe-approved Signifies that QE has signed off on this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 labels Jun 16, 2023
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 16, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #61380

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh added this to the Continuous Release milestone Jun 16, 2023
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #61381

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 16, 2023
Merged
@eromanova97 eromanova97 mentioned this pull request Jun 19, 2023
Merged
@eromanova97 eromanova97 deleted the RHDEVDOCS-5245 branch March 18, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@bburt-rh bburt-rh bburt-rh left review comments

@ppitonak ppitonak ppitonak approved these changes

@jkandasa jkandasa jkandasa approved these changes

@mramendi mramendi mramendi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mramendi mramendi

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

9 participants

@eromanova97 @openshift-ci-robot @ocpdocs-previewbot @mramendi @shipsing @bburt-rh @openshift-cherrypick-robot @ppitonak @jkandasa