Skip to content

Conversation

rh-max
Copy link
Contributor

@rh-max rh-max commented May 29, 2023

Version(s):
Serverless 1.29

Issue:
https://issues.redhat.com/browse/SRVCOM-2320

Link to docs preview:
https://60650--docspreview.netlify.app/openshift-serverless/latest/about/serverless-release-notes.html#serverless-rn-1-29-0_serverless-release-notes

QE review:

  • QE has approved this change.

Notes:

  • @nainaz Note that for both GA/TP table and the deprecated/removed table, I have trimmed 1 oldest version off, as discussed previously. Let me know if there has been a change in this decision.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 29, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 29, 2023

🤖 Updated build preview is available at:
https://60650--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/17246

@rh-max
Copy link
Contributor Author

rh-max commented May 29, 2023

There has been a suggestion to remove all versions but 1.29 from the document, with older versions being in a different page, and we'd have a link to that page. @nainaz and others: WDYT?
(From my POV, it's a -1, because I look at the notes for older versions all the time and keeping them doesn't cost us anything.)

Copy link
Contributor

@nak3 nak3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for serving part except for the FIXME.

@mgencur
Copy link
Contributor

mgencur commented May 30, 2023

Curious if we want to also mention https://issues.redhat.com/browse/SRVCOM-2474 in release notes. Maybe just a note about it and then point to the main docs. We already mention the different channels in RN so it would be good to mention the kn client counterpart of this.
Anyway, SRVCOM-2474 is critical for this release as well.

@rh-max rh-max force-pushed the srvls-release-notes-1.29 branch from ba8751c to d21003c Compare May 30, 2023 13:19
@rh-max
Copy link
Contributor Author

rh-max commented May 30, 2023

Curious if we want to also mention https://issues.redhat.com/browse/SRVCOM-2474 in release notes. Maybe just a note about it and then point to the main docs. We already mention the different channels in RN so it would be good to mention the kn client counterpart of this. Anyway, SRVCOM-2474 is critical for this release as well.

Good idea, added a note about version-locking the kn cli.

@mgencur
Copy link
Contributor

mgencur commented May 30, 2023

@rh-max LGTM except for the FIXME part.

@nainaz
Copy link

nainaz commented May 30, 2023

We should change Knative Kafka to Knative for Apache Kafka

@nainaz
Copy link

nainaz commented May 30, 2023

Looks like we are ready to move Multi Container to GA from TP.
I would say since we just need to work with the label.
Let's move it to GA

@nainaz
Copy link

nainaz commented May 30, 2023

Since we do not document what we add on Dev Console to our docs? should we add this
You can now create OpenShift Serverless functions through DevConsole using Red Hat OpenShift Serverless Pipelines ?
cc @Preeticp @rh-max

@nainaz
Copy link

nainaz commented May 30, 2023

In regards to this issue:
Webhook Horizontal Pod Autoscaler (HPA) settings are overridden by the OpenShift Serverless Operator operator. As a result, it fails to scale for higher workloads.
Do we have any recommendations for the user? @skonto

@nainaz
Copy link

nainaz commented May 30, 2023

@nainaz
Copy link

nainaz commented May 30, 2023

Need to add Release Notes for: https://issues.redhat.com/browse/SRVOCF-520

@skonto
Copy link

skonto commented May 30, 2023

Do we have any recommendations for the user? @skonto

I don't think we have a workaround other than the user to set an initial proper replica value that works for his workload. We will fix this in 1.30 (it is already fixed upstream but we need to bump the knative operator downstream as well). @nak3 may have more to add as he worked on it. We could even do a patch release eg.1.29.1, if possible (to test patch releases as well).

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 2, 2023
@rh-max
Copy link
Contributor Author

rh-max commented Jun 2, 2023

We should change Knative Kafka to Knative for Apache Kafka

@nainaz Knative Kafka is IMO better, because

  1. it's shorter
  2. it has 100+ occurences in the docs, while the "Apache" version has only 2 or 3
  3. it corresponds to how it's written in the UI (Knative Kafka)

Since we do not document what we add on Dev Console to our docs? should we add this
You can now create OpenShift Serverless functions through DevConsole using Red Hat OpenShift Serverless Pipelines ?

Add this to where?

Apart from these, all release notes feedback, all new release notes that appear in the query, and everything that I saw in Slack (no guarantee that I didn't miss something, I only saw the reverse GA/TP table to have the "new, then old" order) has been implemented.

@rh-max
Copy link
Contributor Author

rh-max commented Jun 2, 2023

@nainaz Knative Kafka is IMO better, because

  1. it's shorter
  2. it has 100+ occurences in the docs, while the "Apache" version has only 2 or 3
  3. it corresponds to how it's written in the UI (Knative Kafka)

I had not realized what was the reason for s/Knative Kafka/Knative for Apache Kafka/ and did not know that a firm decision has been reached in https://issues.redhat.com/browse/SRVKE-1421. I have corrected it here.

Since this suggestion:

Since we do not document what we add on Dev Console to our docs? should we add this You can now create OpenShift Serverless functions through DevConsole using Red Hat OpenShift Serverless Pipelines ? cc @Preeticp @rh-max

does not appear to apply to the Release Notes (because this note already is in the release notes), it's out of scope here.

Since all feedback has now been addressed, I'm passing this on for peer-review and merging. If anything urgent appears on Monday, we can create a separate PR for that.

@nainaz
Copy link

nainaz commented Jun 2, 2023

There has been a suggestion to remove all versions but 1.29 from the document, with older versions being in a different page, and we'd have a link to that page. @nainaz and others: WDYT? (From my POV, it's a -1, because I look at the notes for older versions all the time and keeping them doesn't cost us anything.)

I agree, we keep three versions in that table.

@nainaz
Copy link

nainaz commented Jun 2, 2023

user to set an initial proper replica value that works

From @skonto comment, this should be added in known issue:
user to set an initial proper replica value that works manually

@nainaz
Copy link

nainaz commented Jun 2, 2023

This release includes the upgraded Developer Preview for OpenShift Serverless Logic. We need to add link to dev preview docs link. ( we have approval from Sherman) https://issues.redhat.com/browse/SRVLOGIC-153

@nainaz
Copy link

nainaz commented Jun 2, 2023

I have a question about Table 2. GA/TP feature for AWS. We should remove this.

@rh-max
Copy link
Contributor Author

rh-max commented Jun 2, 2023

There has been a suggestion to remove all versions but 1.29 from the document, with older versions being in a different page, and we'd have a link to that page. @nainaz and others: WDYT? (From my POV, it's a -1, because I look at the notes for older versions all the time and keeping them doesn't cost us anything.)

I agree, we keep three versions in that table.

It's a different issue from what we keep in the feature tables.

The new suggestion is to leave only the release notes for Serverless 1.29 on the Release Notes page. Release Notes for Serverless 1.28 and older would go to a different page, and the two pages would be interlinked. (FWIW, I prefer the current approach of a single page for all Serverless versions)

user to set an initial proper replica value that works

From @skonto comment, this should be added in known issue: user to set an initial proper replica value that works manually

Added.

This release includes the upgraded Developer Preview for OpenShift Serverless Logic. We need to add link to dev preview docs link. ( we have approval from Sherman) https://issues.redhat.com/browse/SRVLOGIC-153

It's here, after the known issues (we can only link after the section).

I have a question about Table 2. GA/TP feature for AWS. We should remove this.

Sorry, missed this. Done now.

@rh-max rh-max force-pushed the srvls-release-notes-1.29 branch from 964e022 to 2580edc Compare June 2, 2023 17:46
@gabriel-rh gabriel-rh merged commit 0bcf17e into openshift:serverless-docs Jun 2, 2023
@gabriel-rh
Copy link
Contributor

/cherry-pick serverless-docs-1.29

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #60825

In response to this:

/cherry-pick serverless-docs-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants