-
Notifications
You must be signed in to change notification settings - Fork 1.8k
SRVCOM-2320 Add Serverless 1.29.0 release notes, update feature tables #60650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRVCOM-2320 Add Serverless 1.29.0 release notes, update feature tables #60650
Conversation
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/17246 |
There has been a suggestion to remove all versions but 1.29 from the document, with older versions being in a different page, and we'd have a link to that page. @nainaz and others: WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for serving part except for the FIXME.
Curious if we want to also mention https://issues.redhat.com/browse/SRVCOM-2474 in release notes. Maybe just a note about it and then point to the main docs. We already mention the different channels in RN so it would be good to mention the kn client counterpart of this. |
ba8751c
to
d21003c
Compare
Good idea, added a note about version-locking the kn cli. |
@rh-max LGTM except for the FIXME part. |
We should change Knative Kafka to Knative for Apache Kafka |
Looks like we are ready to move Multi Container to GA from TP. |
In regards to this issue: |
Questions pending on https://issues.redhat.com/browse/SRVKE-1410 |
Need to add Release Notes for: https://issues.redhat.com/browse/SRVOCF-520 |
I don't think we have a workaround other than the user to set an initial proper replica value that works for his workload. We will fix this in 1.30 (it is already fixed upstream but we need to bump the knative operator downstream as well). @nak3 may have more to add as he worked on it. We could even do a patch release eg.1.29.1, if possible (to test patch releases as well). |
@nainaz Knative Kafka is IMO better, because
Add this to where? Apart from these, all release notes feedback, all new release notes that appear in the query, and everything that I saw in Slack (no guarantee that I didn't miss something, I only saw the reverse GA/TP table to have the "new, then old" order) has been implemented. |
I had not realized what was the reason for Since this suggestion:
does not appear to apply to the Release Notes (because this note already is in the release notes), it's out of scope here. Since all feedback has now been addressed, I'm passing this on for peer-review and merging. If anything urgent appears on Monday, we can create a separate PR for that. |
I agree, we keep three versions in that table. |
From @skonto comment, this should be added in known issue: |
This release includes the upgraded Developer Preview for OpenShift Serverless Logic. We need to add link to dev preview docs link. ( we have approval from Sherman) https://issues.redhat.com/browse/SRVLOGIC-153 |
I have a question about Table 2. GA/TP feature for AWS. We should remove this. |
It's a different issue from what we keep in the feature tables. The new suggestion is to leave only the release notes for Serverless 1.29 on the Release Notes page. Release Notes for Serverless 1.28 and older would go to a different page, and the two pages would be interlinked. (FWIW, I prefer the current approach of a single page for all Serverless versions)
Added.
It's here, after the known issues (we can only link after the section).
Sorry, missed this. Done now. |
964e022
to
2580edc
Compare
/cherry-pick serverless-docs-1.29 |
@gabriel-rh: new pull request created: #60825 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
Serverless 1.29
Issue:
https://issues.redhat.com/browse/SRVCOM-2320
Link to docs preview:
https://60650--docspreview.netlify.app/openshift-serverless/latest/about/serverless-release-notes.html#serverless-rn-1-29-0_serverless-release-notes
QE review:
Notes: