Skip to content

OCPBUG#14320: Added a section related to oc-mirror supporting multi-arch images for… #60959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

OCPBUG#14320: Added a section related to oc-mirror supporting multi-arch images for… #60959

merged 1 commit into from
Jun 30, 2023

Conversation

subhtk
Copy link
Contributor

@subhtk subhtk commented Jun 8, 2023 •
edited
Loading

Version(s): 4.14

Issue:
OCPBUG14320

Link to docs preview: Doc Preview

QE review:

  • QE has approved this change.

Additional information:
CFE-783

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 8, 2023
zhouying7780
zhouying7780 reviewed Jun 8, 2023
View reviewed changes
zhouying7780
zhouying7780 reviewed Jun 8, 2023
View reviewed changes
@zhouying7780
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@subhtk
Copy link
Contributor Author

subhtk commented Jun 14, 2023

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 14, 2023
@tmalove
Copy link
Contributor

tmalove commented Jun 14, 2023

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 14, 2023
@tmalove
Copy link
Contributor

tmalove commented Jun 14, 2023

@subhtk Will you add a preview link for your updates? Thanks.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2023
@subhtk
Copy link
Contributor Author

subhtk commented Jun 15, 2023

@subhtk Will you add a preview link for your updates? Thanks.

The preview did not generate automatically. I am trying other means to get the the preview.

@subhtk subhtk closed this Jun 16, 2023
@subhtk subhtk reopened this Jun 16, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 16, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://60959--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/18867

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2023
tmalove
tmalove approved these changes Jun 26, 2023
View reviewed changes
@tmalove
Copy link
Contributor

tmalove commented Jun 26, 2023

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 26, 2023
@subhtk subhtk force-pushed the ocpbug14320 branch 2 times, most recently from dd2d6a0 to 7596070 Compare June 27, 2023 07:52
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2023
@subhtk
Copy link
Contributor Author

subhtk commented Jun 28, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 28, 2023
@zhouying7780
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@zhouying7780
Copy link

/lgtm

@snarayan-redhat snarayan-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 28, 2023
snarayan-redhat
snarayan-redhat reviewed Jun 28, 2023
View reviewed changes
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more changes that might be required before it can be merged.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2023

New changes are detected. LGTM label has been removed.

@subhtk
Copy link
Contributor Author

subhtk commented Jun 28, 2023

@snarayan-redhat Done with changes, please go ahead with merging.

@snarayan-redhat snarayan-redhat merged commit 0226c85 into openshift:enterprise-4.14 Jun 30, 2023
@snarayan-redhat snarayan-redhat added this to the Planned for 4.14 GA milestone Jun 30, 2023
@subhtk subhtk deleted the ocpbug14320 branch June 30, 2023 12:49
@subhtk subhtk restored the ocpbug14320 branch June 30, 2023 12:49
@subhtk subhtk deleted the ocpbug14320 branch July 5, 2023 16:36
@snarayan-redhat snarayan-redhat removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snarayan-redhat snarayan-redhat snarayan-redhat left review comments

+2 more reviewers

@zhouying7780 zhouying7780 zhouying7780 left review comments

@tmalove tmalove tmalove approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zhouying7780 zhouying7780

Labels

branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.14 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@subhtk @zhouying7780 @tmalove @ocpdocs-previewbot @snarayan-redhat @openshift-merge-robot