Skip to content

ML-RHDEVDOCS-2756: Added a new section for monitoring Argo CD instances #62018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

ML-RHDEVDOCS-2756: Added a new section for monitoring Argo CD instances #62018

wants to merge 4 commits into from

Conversation

masauso-lungu
Copy link
Contributor

@masauso-lungu masauso-lungu commented Jul 4, 2023 •
edited
Loading

Jira issue : RHDEVDOCS-2756

Aligned team: DevTools

OCP Version(s): 4.10 and later

Docs preview: 62018--docspreview

SME review: @reginapizza

QE review: @varshab1210

Peer review: @Srivaralakshmi

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 4, 2023 •
edited by openshift-ci bot
Loading

@masauso-lungu: This pull request references RHDEVDOCS-2756 which is a valid jira issue.

In response to this:

Jira issue : RHDEVDOCS-2756

Aligned team: DevTools

OCP Version(s): 4.10 and later

Docs preview: Preview

SME review: @reginapizza

QE review:

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 4, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 4, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://62018--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/22136

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 5, 2023 •
edited by openshift-ci bot
Loading

@masauso-lungu: This pull request references RHDEVDOCS-2756 which is a valid jira issue.

In response to this:

Jira issue : RHDEVDOCS-2756

Aligned team: DevTools

OCP Version(s): 4.10 and later

Docs preview: 62018--docspreview

SME review: @reginapizza

QE review:

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

reginapizza
reginapizza suggested changes Jul 5, 2023
View reviewed changes
reginapizza
reginapizza suggested changes Jul 18, 2023
View reviewed changes
@reginapizza
Copy link
Contributor

Just the one comment and then I'm okay to approve it!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 20, 2023 •
edited by openshift-ci bot
Loading

@masauso-lungu: This pull request references RHDEVDOCS-2756 which is a valid jira issue.

In response to this:

Jira issue : RHDEVDOCS-2756

Aligned team: DevTools

OCP Version(s): 4.10 and later

Docs preview: 62018--docspreview

SME review: @reginapizza

QE review: @varshab1210

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@varshab1210
Copy link

LGTM, thanks!

bburt-rh
bburt-rh reviewed Jul 21, 2023
View reviewed changes
Srivaralakshmi
Srivaralakshmi suggested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masauso-lungu Good work! Thanks for the time and effort! PTAL at the suggestions.

Ensure you address all of them without missing any of them.

@Srivaralakshmi
Copy link
Contributor

Srivaralakshmi commented Aug 1, 2023 •
edited
Loading

@masauso-lungu Any progress on this PR? Have you resolved the peer review comments given by me?

@reginapizza and @varshab1210: Can you PTAL at the queries in my review comments and respond? Thank you!

@reginapizza
Copy link
Contributor

@Srivaralakshmi changes look okay to me, once they're addressed I'll approve :)

@masauso-lungu
Copy link
Contributor Author

Hello @reginapizza , @varshab1210 and @Srivaralakshmi ,
All queries have been resolved, PTAL.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 16, 2023 •
edited by openshift-ci bot
Loading

@masauso-lungu: This pull request references RHDEVDOCS-2756 which is a valid jira issue.

In response to this:

Jira issue : RHDEVDOCS-2756

Aligned team: DevTools

OCP Version(s): 4.10 and later

Docs preview: 62018--docspreview

SME review: @reginapizza

QE review: @varshab1210

Peer review: @Srivaralakshmi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Srivaralakshmi
Srivaralakshmi suggested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masauso-lungu Nice work and thanks for the changes! Minor nitpicks. PTAL.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 23, 2023
themr0c
themr0c reviewed Aug 24, 2023
View reviewed changes
_topic_maps/_topic_map.yml
File: creating-multi-arch-compute-nodes-bare-metal
- Name: Managing your cluster with multi-architecture compute machines
File: multi-architecture-compute-managing
File: multi-architecture-configuration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new line is causing the build error

@masauso-lungu
ML-RHDEVDOCS-2756: Added a new section for monitoring Argo CD instances
903bbde 
Corrected a typo.

Update to address 1st SME review.

corrected a typo

Miner update to address QE review.

update to resolve build errors

Update to address peer review.
@masauso-lungu masauso-lungu mentioned this pull request Aug 24, 2023
Merged
@varshab1210
Copy link

LGTM

@masauso-lungu masauso-lungu deleted the ML-RHDEVDOCS-2756 branch October 18, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@themr0c themr0c themr0c left review comments

@varshab1210 varshab1210 varshab1210 left review comments

@bburt-rh bburt-rh bburt-rh left review comments

@Srivaralakshmi Srivaralakshmi Srivaralakshmi requested changes

@reginapizza reginapizza reginapizza approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@masauso-lungu @openshift-ci-robot @ocpdocs-previewbot @reginapizza @varshab1210 @Srivaralakshmi @themr0c @bburt-rh