Skip to content

OSDOCS-7625: add GA and update release notes 4.14 #64195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2023
Merged

OSDOCS-7625: add GA and update release notes 4.14 #64195

merged 1 commit into from
Sep 6, 2023

Conversation

ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Aug 31, 2023 •
edited
Loading

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 31, 2023 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-7625 which is a valid jira issue.

In response to this:

Version(s):
4.14

Issue:
https://issues.redhat.com/browse/OSDOCS-7625

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 31, 2023
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 31, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 31, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://64195--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/23815

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 31, 2023 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-7625 which is a valid jira issue.

In response to this:

Version(s):
4.14

Issue:
https://issues.redhat.com/browse/OSDOCS-7625

Link to docs preview:
https://64195--docspreview.netlify.app/microshift/latest/microshift_release_notes/microshift-4-14-release-notes#microshift-4-14-about-this-release
https://64195--docspreview.netlify.app/microshift/latest/microshift_release_notes/microshift-4-14-release-notes#microshift-4-14-updates-supported

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShaunaDiaz
Copy link
Contributor Author

@DanielFroehlich PTAL at the "About this release" section. Do we have any Lifecycle dates? I have one that I grabbed from OCP there as a placeholder.

@ShaunaDiaz
Copy link
Contributor Author

@pmtk and @dhellmann PTAL at the Updates section (and anything else you want to).

DanielFroehlich
DanielFroehlich reviewed Sep 1, 2023
View reviewed changes
dhellmann
dhellmann reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have anything to add beyond what Daniel had to say.

@dhensel-rh
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 5, 2023 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-7625 which is a valid jira issue.

In response to this:

Version(s):
4.14

Issue:
https://issues.redhat.com/browse/OSDOCS-7625

Link to docs preview:
https://64195--docspreview.netlify.app/microshift/latest/microshift_release_notes/microshift-4-14-release-notes#microshift-4-14-about-this-release
https://64195--docspreview.netlify.app/microshift/latest/microshift_release_notes/microshift-4-14-release-notes#microshift-4-14-updates-supported

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShaunaDiaz
Copy link
Contributor Author

@DanielFroehlich PTAL and LGTM if ready? Thank you!

@DanielFroehlich
Copy link

Last comment: In the "Networking changes section", the changes are pretty high level summaries. Can we please add a link to the Networking section doc where this is being explained a bit more detailed?

@ShaunaDiaz
Copy link
Contributor Author

ShaunaDiaz commented Sep 6, 2023 •
edited
Loading

@DanielFroehlich The networking release note is being done in a separate PR. So, yes, there is more detail and a link.

@ShaunaDiaz
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 6, 2023
@DanielFroehlich
Copy link

Thx, and sorry I did not saw that other PR. Then this
/lgtm

@DanielFroehlich
Copy link

/lgtm

@skopacz1
Copy link
Contributor

skopacz1 commented Sep 6, 2023

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 6, 2023
skopacz1
skopacz1 reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions, otherwise looks good!

@skopacz1
Copy link
Contributor

skopacz1 commented Sep 6, 2023

/remove-label peer-review-needed
/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 6, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

New changes are detected. LGTM label has been removed.

@ShaunaDiaz
Copy link
Contributor Author

/label merge-review-needed

@ShaunaDiaz
Copy link
Contributor Author

Note other MicroShift relnote PRs are also in the merge review queue.

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 6, 2023
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 6, 2023
jeana-redhat
jeana-redhat approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 6, 2023
@jeana-redhat jeana-redhat merged commit 9251215 into openshift:enterprise-4.14 Sep 6, 2023
@jeana-redhat jeana-redhat added this to the Planned for 4.14 GA milestone Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skopacz1 skopacz1 skopacz1 left review comments

@jeana-redhat jeana-redhat jeana-redhat approved these changes

+3 more reviewers

@dhellmann dhellmann dhellmann left review comments

@pmtk pmtk pmtk left review comments

@DanielFroehlich DanielFroehlich DanielFroehlich left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@DanielFroehlich DanielFroehlich

@dhensel-rh dhensel-rh

Labels

branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.14 GA

Development

Successfully merging this pull request may close these issues.

9 participants

@ShaunaDiaz @openshift-ci-robot @ocpdocs-previewbot @dhensel-rh @DanielFroehlich @skopacz1 @dhellmann @pmtk @jeana-redhat