CNV-29048: Release note: CHANGE (metrics changes) #64674
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@aspauldi: This pull request references CNV-29048 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/XS
|
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/31055 |
|
@aspauldi: This pull request references CNV-29048 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@aspauldi: This pull request references CNV-29048 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sradco , I've created the release note. The link to the article won't work until it is published, but can you please review the note text? Thanks. |
|
@sradco, Can you take a look at the release note? Thanks! |
| //CNV-28732 Release note: NEW | ||
|
|
||
| //CNV-29048 Release note: NEW Metrics name changes | ||
| * Many OpenShift Virtualization metrics have changed. These changes could affect your custom dashboards. See link:https://access.redhat.com/articles/7028805[OpenShift Virtualization 4.14 metric changes] for details. |
There was a problem hiding this comment.
Hi @aspauldi, Please comment that the link includes both metrics that changed name and deprecated metrics that would change in 4.15.
There was a problem hiding this comment.
Sorry, it's all about metrics. I made a mistake in the comment and updated it now
There was a problem hiding this comment.
How would metrics deprecated in 4.14 change in 4.15? Would the metrics still exist in 4.15 (removal would happen at some point in the future, after 4.15) but be renamed?
|
@kmajcher-rh, would you be able to look at this PR (in lieu of Shirly)? Thanks |
|
@aspauldi - i just have one question about "The following metrics are deprecated in 4.14 and will be changed in 4.15." section, which is followed by a table with list of metrics with old and new name. I assume new name will be effective in 4.15 only, and old name still works in 4.14? Is this how a reader should understand this? |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
Hi @kmajcher-rh, I was confused about that too, what is meant by "The following metrics are deprecated in 4.14 and will be changed in 4.15." I had asked Shirly about that in a comment last week (see comment ^) and was awaiting her response. Perhaps we need to wait for Shirly to review? |
|
@aspauldi Please make sure to reference the correct BZ https://bugzilla.redhat.com/show_bug.cgi?id=2179660 / Jira https://issues.redhat.com/browse/CNV-27054 issue number. Please note that CNV-29048 is a tracker issue for the release note and the bug needs to reference the original BZ 2179660 |
|
/label cnv |
|
Hi @sradco, When you are able, can you take a look at my question above? Thanks very much. |
| * You can use a xref:../../virt/virtual_machines/advanced_vm_management/virt-schedule-vms.adoc#virt-vm-custom-scheduler_virt-schedule-vms[custom scheduler] to schedule a virtual machine (VM) on a node. | ||
| //CNV-29048 Release note: NEW Metrics name changes | ||
| * Many OpenShift Virtualization metrics have changed. These changes could affect your custom dashboards. See link:https://access.redhat.com/articles/7028805[OpenShift Virtualization 4.14 metric changes] for details. | ||
|
|
There was a problem hiding this comment.
I would say that "many metrics names changed or will be changed in the next version."
There was a problem hiding this comment.
@aspauldi Unfortunately, the link to https://access.redhat.com/articles/7028805 is a private link for internal Red Hat only, so it won't benefit our customers.
I recommend including both of the tables in the article (4.14 changed metrics and 4.14 deprecated metrics) in the release notes. @apinnick do you agree that we should include these tables since the link to the article is not accessible by customers?
| //CNV-28729 Release note: New | ||
| * You can use a xref:../../virt/virtual_machines/advanced_vm_management/virt-schedule-vms.adoc#virt-vm-custom-scheduler_virt-schedule-vms[custom scheduler] to schedule a virtual machine (VM) on a node. | ||
| //CNV-29048 Release note: NEW Metrics name changes | ||
| * Many OpenShift Virtualization metrics have changed or will change in a future version. These changes could affect your custom dashboards. See link:https://access.redhat.com/articles/7028805[OpenShift Virtualization 4.14 metric changes] for details. |
There was a problem hiding this comment.
@aspauldi the linked document has "PRIVATE: This document is for internal use and is not accessible to customers." header, is it appropriate for release note, that would be out for public consumption?
@sradco https://access.redhat.com/articles/7028805 includes metrics that would be renamed in 4.15. Referencing it without clearly mentioning which are getting updated in 4.14 vs 4.15, would be more confusing I feel.
There was a problem hiding this comment.
@apinnick I see the article https://access.redhat.com/articles/7028805 is published, but some of the metrics that are mentioned there did not get renamed till 4.15. This would be misleading. @sradco what do you suggest we do?
|
Hi @dbasunag, the article is published. Can you please review? Thanks! |
|
@sradco We would like you to review and clarify the wording in the article to be clear about what changed in 4.14. https://access.redhat.com/articles/7028805 The article must be clear about:
If there are metrics that will change in 4.15, please list them separately, or don't mention them at all since 4.15 is not yet released. Thank you |
|
We need to notify our customers on coming changes in 4.15 so that they can plan to update their metrics collection pipelines in case they use an external monitoring stack. This is the reason we also list the metrics that are deprecated in 4.14 and in 4.15 will have a new name. |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
|
/label peer-review-in-progress |
openshift-ci
bot
added
the
peer-review-in-progress
|
/remove-label peer-review-needed |
|
@aspauldi: This pull request references CNV-29048 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
|
/label peer-review-done |
openshift-ci
bot
added
the
peer-review-done
|
/remove-label peer-review-needed |
openshift-ci
bot
removed
peer-review-needed
mburke5678
added
merge-review-in-progress
11 participants
Version(s): 4.14
Issue: CNV-29048
Link to docs preview: New and changed features
QE review:
Additional information: