Skip to content

TELCODOCS-1537: Custom source CRs for PolicyGenTemplate CR #64715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

TELCODOCS-1537: Custom source CRs for PolicyGenTemplate CR #64715

merged 1 commit into from
Oct 10, 2023

Conversation

@amolnar-gh
Copy link
Contributor

@amolnar-gh amolnar-gh commented Sep 14, 2023 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 14, 2023 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1537 which is a valid jira issue.

In response to this:

Version(s): 4.12

Issue: https://issues.redhat.com/browse/TELCODOCS-1537

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 14, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 14, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://64715--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/26610

@amolnar-gh amolnar-gh force-pushed the TELCODOCS-1537-4.12 branch 2 times, most recently from c08878c to e5ac6cf Compare September 22, 2023 09:38
sabbir-47
sabbir-47 reviewed Sep 22, 2023
View reviewed changes
sabbir-47
sabbir-47 reviewed Sep 22, 2023
View reviewed changes
sabbir-47
sabbir-47 reviewed Sep 22, 2023
View reviewed changes
@sabbir-47
Copy link

sabbir-47 commented Sep 22, 2023

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

@sabbir-47: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slovern slovern mentioned this pull request Sep 22, 2023
Merged
1 task
@amolnar-gh
Copy link
Contributor Author

amolnar-gh commented Sep 25, 2023

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 25, 2023
@skopacz1
Copy link
Contributor

skopacz1 commented Sep 25, 2023

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 25, 2023
@skopacz1
Copy link
Contributor

skopacz1 commented Sep 25, 2023

Hi! I'll start my review shortly, but in the meantime can you add this preview link to your comment 0? Adding custom content to the GitOps ZTP pipeline

(Or the correct link if I got it wrong)

skopacz1
skopacz1 reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! Just left a few comments and suggestions.

@skopacz1
Copy link
Contributor

skopacz1 commented Sep 25, 2023

/remove-label peer-review-needed
/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 25, 2023
@skopacz1
Copy link
Contributor

skopacz1 commented Sep 25, 2023

Whoops, I also forgot to mention: please squash all your commits to 1 before requesting a merge review as well. Thanks!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2023 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1537 which is a valid jira issue.

In response to this:

Version(s): 4.12

Issue: https://issues.redhat.com/browse/TELCODOCS-1537

Link to docs preview: https://64715--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-advanced-policy-config#ztp-adding-new-content-to-gitops-ztp_ztp-advanced-policy-config

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amolnar-gh amolnar-gh force-pushed the TELCODOCS-1537-4.12 branch 2 times, most recently from 6b6c53e to 219ca07 Compare September 26, 2023 16:05
@amolnar-gh amolnar-gh force-pushed the TELCODOCS-1537-4.12 branch from 219ca07 to 353b13e Compare October 3, 2023 13:51
@mpmaruthu
Copy link

mpmaruthu commented Oct 6, 2023

Telco QE: Looks good to me.
/Peri M

@aireilly
Copy link
Contributor

aireilly commented Oct 6, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1537 which is a valid jira issue.

In response to this:

Version(s): 4.12

Issue: https://issues.redhat.com/browse/TELCODOCS-1537

Link to docs preview: https://64715--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-advanced-policy-config#ztp-adding-new-content-to-gitops-ztp_ztp-advanced-policy-config

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lpettyjo lpettyjo added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1537 which is a valid jira issue.

In response to this:

Version(s): 4.12

Issue: https://issues.redhat.com/browse/TELCODOCS-1537

Link to docs preview: https://64715--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-advanced-policy-config#ztp-adding-new-content-to-gitops-ztp_ztp-advanced-policy-config

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lpettyjo lpettyjo self-requested a review October 6, 2023 13:56
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1537 which is a valid jira issue.

In response to this:

Version(s): 4.12

Issue: https://issues.redhat.com/browse/TELCODOCS-1537

Link to docs preview: https://64715--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-advanced-policy-config#ztp-adding-new-content-to-gitops-ztp_ztp-advanced-policy-config

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lpettyjo lpettyjo added this to the Continuous Release milestone Oct 6, 2023
@lpettyjo lpettyjo added ok-to-merge and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Oct 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2023 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1537 which is a valid jira issue.

In response to this:

Version(s): 4.12

Issue: https://issues.redhat.com/browse/TELCODOCS-1537

Link to docs preview: https://64715--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-advanced-policy-config#ztp-adding-new-content-to-gitops-ztp_ztp-advanced-policy-config

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aireilly
Copy link
Contributor

aireilly commented Oct 10, 2023

/remove-label merge-review-needed

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

@aireilly: Those labels are not set on the issue: merge-review-needed

In response to this:

/remove-label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aireilly
Copy link
Contributor

aireilly commented Oct 10, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 10, 2023
@abhatt-rh
Copy link
Contributor

abhatt-rh commented Oct 10, 2023

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 10, 2023
@abhatt-rh abhatt-rh merged commit adb406b into openshift:enterprise-4.12 Oct 10, 2023
This was referenced Oct 13, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slovern slovern slovern left review comments

@skopacz1 skopacz1 skopacz1 left review comments

@lpettyjo lpettyjo Awaiting requested review from lpettyjo

+1 more reviewer

@sabbir-47 sabbir-47 sabbir-47 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.12 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR ok-to-merge peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

10 participants

@amolnar-gh @openshift-ci-robot @ocpdocs-previewbot @sabbir-47 @skopacz1 @mpmaruthu @aireilly @abhatt-rh @slovern @lpettyjo