Skip to content

[WIP] [DO NOT MERGE] [RHDEVDOCS-5452] Bump versions to 1.12 #65179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WIP] [DO NOT MERGE] [RHDEVDOCS-5452] Bump versions to 1.12 #65179

wants to merge 2 commits into from

Conversation

krishnanshruthi
Copy link
Contributor

@krishnanshruthi krishnanshruthi commented Sep 25, 2023 •
edited
Loading

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 25, 2023
@krishnanshruthi krishnanshruthi changed the title [RHDEVDOCS-5452] Bump versions to 1.11 [RHDEVDOCS-5452] Bump versions to 1.12 Sep 25, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 25, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://65179--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/26032

@mramendi
Copy link
Contributor

peer review LGTM

@mramendi
Copy link
Contributor

This needs to also be cherry-picked to pipelines-docs-4.12 please. The cherry-pick should work automatically I think

@piyush-garg
Copy link

lgtm

@krishnanshruthi krishnanshruthi changed the title [RHDEVDOCS-5452] Bump versions to 1.12 [WIP] [DO NOT MERGE] [RHDEVDOCS-5452] Bump versions to 1.12 Sep 26, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2023
@krishnanshruthi
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 26, 2023
@krishnanshruthi
Copy link
Contributor Author

Please DO NOT merge this issue. The intention is to keep the PRs merge ready with all approvals. The PR merging can happen only on the GA date (September 26th). So please hold off merging until I let you know. thank you!

@opayne1
Copy link
Contributor

opayne1 commented Sep 26, 2023

Does the 1.11 here need to be updated to 1.12?
otherwise /lgtm

@opayne1 opayne1 added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 26, 2023
@opayne1 opayne1 added this to the Continuous Release milestone Sep 26, 2023
@ppitonak
Copy link

Does the 1.11 here need to be updated to 1.12? otherwise /lgtm

IMHO we can remove the pipelines-1.11 string altogether.

@krishnanshruthi
Copy link
Contributor Author

Does the 1.11 here need to be updated to 1.12? otherwise /lgtm

IMHO we can remove the pipelines-1.11 string altogether.

Removed: 67f8c00

@ppitonak
Copy link

FYI all links are live now and I verified that they work

@mramendi
Copy link
Contributor

Please ask for a cherry-pick to pipelines-docs and pipelines-docs-1.12 too when requesting the merge review. From what I see, automatic cherry-picking should work fine with this PR.

@mramendi
Copy link
Contributor

mramendi commented Oct 17, 2023 •
edited by openshift-ci bot
Loading

The PR is not getting merged after all. I am working on RHDEVDOCS-5669 that will remove the need for such PRs.

@krishnanshruthi
Copy link
Contributor Author

Closing this PR as Mikhail is handling this PR through https://issues.redhat.com//browse/RHDEVDOCS-5669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@vdemeester vdemeester vdemeester approved these changes

@ppitonak ppitonak ppitonak approved these changes

@khrm khrm khrm approved these changes

@mramendi mramendi mramendi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. merge-review-in-progress Signifies that the merge review team is reviewing this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

8 participants

@krishnanshruthi @ocpdocs-previewbot @mramendi @piyush-garg @opayne1 @ppitonak @vdemeester @khrm