Skip to content

Conversation

@aireilly
Copy link
Contributor

@aireilly aireilly commented Oct 10, 2023

Cherrypicks review changes from #64949 for TELCODOCS-1085 that were done in main after the original PR was merged.

Version(s):
enterprise-4.12

Issue:
https://issues.redhat.com/browse/TELCODOCS-1085

Link to docs preview: https://65995--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-advanced-policy-config

QE review:

  • QE has approved this change in the original PR on main.

@aireilly
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 10, 2023
@aireilly aireilly changed the title TELCODOCS-1085 - cherrypick custom source CRs for PolicyGenTemplate CRs TELCODOCS-1085 - cherrypick late review comments to enterprise-4.12 Oct 10, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 10, 2023

🤖 Updated build preview is available at:
https://65995--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/27288

@maxwelldb maxwelldb added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 10, 2023
@maxwelldb maxwelldb self-requested a review October 10, 2023 13:39
@maxwelldb maxwelldb added this to the Continuous Release milestone Oct 10, 2023
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@maxwelldb maxwelldb added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 10, 2023
@aireilly aireilly force-pushed the enterprise-4.12-TELCODOCS-1085-nits branch from 7491a55 to d5225c9 Compare October 10, 2023 15:04
@aireilly
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 10, 2023
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge review lgtm

@skrthomas skrthomas merged commit 1782b6a into openshift:enterprise-4.12 Oct 10, 2023
@amolnar-gh amolnar-gh mentioned this pull request Oct 13, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.12 merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants