Skip to content

OSSM-3159 Remove routerMode: sni-dnat from federation docs #69120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

OSSM-3159 Remove routerMode: sni-dnat from federation docs #69120

merged 1 commit into from
Dec 12, 2023

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Dec 7, 2023 •
edited
Loading

OSSM-3159 Remove "routerMode: sni-dnat" from federation docs

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OSSM-3159

Link to docs preview:
https://69120--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-federation#ossm-federation-config-smcp_federation

QE review:

  • QE has approved this change.

Additional information:

OSSM 2.1 is no longer supported so "routerMode: sni-dnat" has been removed instead of adding "Required only in OSSM 2.1".

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 7, 2023 •
edited
Loading

🤖 Mon Dec 11 17:06:09 - Prow CI generated the docs preview: https://69120--ocpdocs-pr.netlify.app

@gwynnemonahan gwynnemonahan force-pushed the OSSM-3159 branch 4 times, most recently from 6e885b8 to 54e70fc Compare December 11, 2023 13:40
monroe-dylan-m
monroe-dylan-m suggested changes Dec 11, 2023
View reviewed changes
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 11, 2023

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gwynnemonahan
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 11, 2023
skrthomas
skrthomas reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@skrthomas skrthomas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 11, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2023
@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 11, 2023
@bburt-rh bburt-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR qe-approved Signifies that QE has signed off on this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 12, 2023
@bburt-rh bburt-rh added this to the Continuous Release milestone Dec 12, 2023
@bburt-rh bburt-rh merged commit 18c6da3 into openshift:main Dec 12, 2023
@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #69246

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Dec 12, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #69247

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skrthomas skrthomas skrthomas left review comments

+2 more reviewers

@yxun yxun yxun approved these changes

@monroe-dylan-m monroe-dylan-m monroe-dylan-m approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skrthomas skrthomas

Labels

dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

7 participants

@gwynnemonahan @ocpdocs-previewbot @bburt-rh @openshift-cherrypick-robot @yxun @monroe-dylan-m @skrthomas