Skip to content

OCPBUGS-22329 Issue in file welcome/oke_about.adoc #69210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

OCPBUGS-22329 Issue in file welcome/oke_about.adoc #69210

merged 1 commit into from
Dec 12, 2023

Conversation

libander
Copy link
Contributor

Replaces 68290

Version(s):
4.13+

Issue:
OCPBUGS-22329 Issue in file welcome/oke_about.adoc

QE review:

QE has approved this change.
Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2023
@ocpdocs-previewbot
Copy link

🤖 Mon Dec 11 17:41:53 - Prow CI generated the docs preview: https://69210--ocpdocs-pr.netlify.app

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 11, 2023

@libander: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@libander
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 11, 2023
@skrthomas skrthomas added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 11, 2023
@skrthomas
Copy link
Contributor

@libander can you please link your preview? Thank you! Sorry I don't know where in the repo oke_about would be 🤷‍♀️ else I would look myself.

@skrthomas skrthomas added peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Dec 11, 2023
@lahinson
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 12, 2023
anpingli
anpingli reviewed Dec 12, 2023
View reviewed changes
Copy link

@anpingli anpingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2023
@lahinson
Copy link
Contributor

For peer-review purposes, I'm assuming that this is the correct preview link: https://69210--ocpdocs-pr.netlify.app/openshift-enterprise/latest/welcome/oke_about

lahinson
lahinson reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lahinson
Copy link
Contributor

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Dec 12, 2023
@libander
Copy link
Contributor Author

@libander can you please link your preview? Thank you! Sorry I don't know where in the repo oke_about would be 🤷‍♀️ else I would look myself.

Apologies, it hadn't generated right away yesterday.

@libander
Copy link
Contributor Author

For peer-review purposes, I'm assuming that this is the correct preview link: https://69210--ocpdocs-pr.netlify.app/openshift-enterprise/latest/welcome/oke_about

Yes, thank you!

@libander
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 12, 2023
@sjhala-ccs sjhala-ccs added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.13 branch/enterprise-4.14 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 12, 2023
@sjhala-ccs sjhala-ccs added this to the Continuous Release milestone Dec 12, 2023
@sjhala-ccs sjhala-ccs removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 12, 2023
@sjhala-ccs sjhala-ccs merged commit 2fa632f into openshift:main Dec 12, 2023
@sjhala-ccs
Copy link
Contributor

/cherrypick enterprise-4.13

@sjhala-ccs
Copy link
Contributor

/cherrypick enterprise-4.14

@sjhala-ccs
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 12, 2023
Merged
@openshift-cherrypick-robot
Copy link

@sjhala-ccs: new pull request created: #69266

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@sjhala-ccs: new pull request created: #69267

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 12, 2023
Merged
@openshift-cherrypick-robot
Copy link

@sjhala-ccs: new pull request created: #69268

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahinson lahinson lahinson left review comments

+1 more reviewer

@anpingli anpingli anpingli left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@anpingli anpingli

Labels

branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

7 participants

@libander @ocpdocs-previewbot @skrthomas @lahinson @sjhala-ccs @openshift-cherrypick-robot @anpingli