Skip to content

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Dec 22, 2023

Aligned team: Dev Tools

Version(s): CP to gitops-docs-1.10, gitops-docs-1.11

Issue: RHDEVDOCS-5856

Preview links:

Change Management

Additional information:

  • This issue adds the missing TP notices to the round-robin sharding algorithm and dynamic scaling of shards and also adds them to the TP feature table.
  • Both the features went TP in 1.10 release.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 22, 2023

@ekristova: This pull request references RHDEVDOCS-5856 which is a valid jira issue.

In response to this:

Version(s): CP to gitops-docs-1.10, gitops-docs-1.11

Issue: RHDEVDOCS-5856

Preview link:

SME review:

QE review:

Peer review:

Additional information: This issue needs to go though change management

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 22, 2023
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 22, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 22, 2023

🤖 Updated build preview is available at:
https://69691--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37128

…namic scaling of shards features to the TP table of 1.10 RN
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2024

@ekristova: This pull request references RHDEVDOCS-5856 which is a valid jira issue.

In response to this:

Version(s): CP to gitops-docs-1.10, gitops-docs-1.11

Issue: RHDEVDOCS-5856

Preview link:

Additional information: This issue needs to go though change management

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2024

@ekristova: This pull request references RHDEVDOCS-5856 which is a valid jira issue.

In response to this:

Version(s): CP to gitops-docs-1.10, gitops-docs-1.11

Issue: RHDEVDOCS-5856

Preview link:

Additional information:

  • This issue adds the missing TP notices to the round-robin sharding algorithm and dynamic scaling of shards and also adds them to the TP feature table.
  • Both the features went TP in 1.10 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97
Copy link
Contributor Author

Hello @iam-veeramalla @jannfis @RickJWagner @varshab1210 @harrietgrace @Preeticp
because this PR needs to go through the change management process, could you please take a look and give your feedback / approvals? Thank you!

@eromanova97 eromanova97 changed the title [WIP] RHDEVDOCS-5856: Add the round-robin cluster sharding algorithm and dy… RHDEVDOCS-5856: Add the round-robin cluster sharding algorithm and dy… Jan 9, 2024
Copy link

openshift-ci bot commented Jan 9, 2024

@ekristova: The label(s) /remove-label do-not-merge/work-in-progress cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label do-not-merge/work-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eromanova97 eromanova97 changed the title RHDEVDOCS-5856: Add the round-robin cluster sharding algorithm and dy… [WIP] RHDEVDOCS-5856: Add the round-robin cluster sharding algorithm and dy… Jan 9, 2024
@eromanova97 eromanova97 changed the title [WIP] RHDEVDOCS-5856: Add the round-robin cluster sharding algorithm and dy… RHDEVDOCS-5856: Add the round-robin cluster sharding algorithm and dy… Jan 9, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2024

@ekristova: This pull request references RHDEVDOCS-5856 which is a valid jira issue.

In response to this:

Version(s): CP to gitops-docs-1.10, gitops-docs-1.11

Issue: RHDEVDOCS-5856

Preview link:

Change Management
Need an ACK from Eng: @iam-veeramalla @jannfis
Need an ACK from PM: @harrietgrace
Need an ACK from Product experience: @RickJWagner
Need an ACK from QE: @varshab1210
Need an ACK from CS: @Preeticp

Additional information:

  • This issue adds the missing TP notices to the round-robin sharding algorithm and dynamic scaling of shards and also adds them to the TP feature table.
  • Both the features went TP in 1.10 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2024

@ekristova: This pull request references RHDEVDOCS-5856 which is a valid jira issue.

In response to this:

Version(s): CP to gitops-docs-1.10, gitops-docs-1.11

Issue: RHDEVDOCS-5856

Preview links:

Change Management
Need an ACK from Eng: @iam-veeramalla @jannfis
Need an ACK from PM: @harrietgrace
Need an ACK from Product experience: @RickJWagner
Need an ACK from QE: @varshab1210
Need an ACK from CS: @Preeticp

Additional information:

  • This issue adds the missing TP notices to the round-robin sharding algorithm and dynamic scaling of shards and also adds them to the TP feature table.
  • Both the features went TP in 1.10 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2024

@ekristova: This pull request references RHDEVDOCS-5856 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools

Version(s): CP to gitops-docs-1.10, gitops-docs-1.11

Issue: RHDEVDOCS-5856

Preview links:

Change Management
Need an ACK from Eng: @iam-veeramalla @jannfis
Need an ACK from PM: @harrietgrace
Need an ACK from Product experience: @RickJWagner
Need an ACK from QE: @varshab1210
Need an ACK from CS: @Preeticp

Additional information:

  • This issue adds the missing TP notices to the round-robin sharding algorithm and dynamic scaling of shards and also adds them to the TP feature table.
  • Both the features went TP in 1.10 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@RickJWagner
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jan 9, 2024
@Preeticp
Copy link
Contributor

CS ack

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2024

@ekristova: This pull request references RHDEVDOCS-5856 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools

Version(s): CP to gitops-docs-1.10, gitops-docs-1.11

Issue: RHDEVDOCS-5856

Preview links:

Change Management

Additional information:

  • This issue adds the missing TP notices to the round-robin sharding algorithm and dynamic scaling of shards and also adds them to the TP feature table.
  • Both the features went TP in 1.10 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@varshab1210
Copy link

LGTM, thanks

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2024

@ekristova: This pull request references RHDEVDOCS-5856 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools

Version(s): CP to gitops-docs-1.10, gitops-docs-1.11

Issue: RHDEVDOCS-5856

Preview links:

Change Management

Additional information:

  • This issue adds the missing TP notices to the round-robin sharding algorithm and dynamic scaling of shards and also adds them to the TP feature table.
  • Both the features went TP in 1.10 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@harrietgrace
Copy link

Looks great, thanks @ekristova!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2024

@ekristova: This pull request references RHDEVDOCS-5856 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools

Version(s): CP to gitops-docs-1.10, gitops-docs-1.11

Issue: RHDEVDOCS-5856

Preview links:

Change Management

Additional information:

  • This issue adds the missing TP notices to the round-robin sharding algorithm and dynamic scaling of shards and also adds them to the TP feature table.
  • Both the features went TP in 1.10 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jannfis
Copy link

jannfis commented Jan 16, 2024

LGTM

@iam-veeramalla
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2024

@ekristova: This pull request references RHDEVDOCS-5856 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools

Version(s): CP to gitops-docs-1.10, gitops-docs-1.11

Issue: RHDEVDOCS-5856

Preview links:

Change Management

Additional information:

  • This issue adds the missing TP notices to the round-robin sharding algorithm and dynamic scaling of shards and also adds them to the TP feature table.
  • Both the features went TP in 1.10 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 17, 2024
@kcarmichael08 kcarmichael08 added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 17, 2024
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is applicable, but should the technology preview snippet be in the RNs somewhere? (with the standard boilerplate language) Maybe it's not normally included in the Release Notes for gitops but I thought I would ask.

Everything looks good to me!

@kcarmichael08 kcarmichael08 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 17, 2024
@eromanova97
Copy link
Contributor Author

I'm not sure if this is applicable, but should the technology preview snippet be in the RNs somewhere? (with the standard boilerplate language) Maybe it's not normally included in the Release Notes for gitops but I thought I would ask.

Everything looks good to me!

Hello @kcarmichael08 yes thank you for your question! In the release notes, we just include this small admonition instead of snippet. In the assembly for the feature, we include it as a snippet as per usual. Thank you!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 18, 2024

@ekristova: This pull request references RHDEVDOCS-5856 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools

Version(s): CP to gitops-docs-1.10, gitops-docs-1.11

Issue: RHDEVDOCS-5856

Preview links:

Change Management

Additional information:

  • This issue adds the missing TP notices to the round-robin sharding algorithm and dynamic scaling of shards and also adds them to the TP feature table.
  • Both the features went TP in 1.10 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2024

@ekristova: This pull request references RHDEVDOCS-5856 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools

Version(s): CP to gitops-docs-1.10, gitops-docs-1.11

Issue: RHDEVDOCS-5856

Preview links:

Change Management

Additional information:

  • This issue adds the missing TP notices to the round-robin sharding algorithm and dynamic scaling of shards and also adds them to the TP feature table.
  • Both the features went TP in 1.10 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 19, 2024
@sheriff-rh sheriff-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 19, 2024
Copy link
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging.

@sheriff-rh sheriff-rh merged commit b5b9b3b into openshift:gitops-docs Jan 19, 2024
@sheriff-rh
Copy link
Contributor

/cherrypick gitops-docs-1.11

@sheriff-rh
Copy link
Contributor

/cherrypick gitops-docs-1.10

@openshift-cherrypick-robot

@sheriff-rh: #69691 failed to apply on top of branch "gitops-docs-1.10":

Applying: RHDEVDOCS-5856: Add the round-robin cluster sharding algorithm and dynamic scaling of shards features to the TP table of 1.10 RN
.git/rebase-apply/patch:17: trailing whitespace.
The `round-robin` sharding algorithm is a Technology Preview feature. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	modules/gitops-release-notes-1-10-0.adoc
M	modules/go-compatibility-and-support-matrix.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/go-compatibility-and-support-matrix.adoc
CONFLICT (content): Merge conflict in modules/go-compatibility-and-support-matrix.adoc
Auto-merging modules/gitops-release-notes-1-10-0.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHDEVDOCS-5856: Add the round-robin cluster sharding algorithm and dynamic scaling of shards features to the TP table of 1.10 RN
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick gitops-docs-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #70565

In response to this:

/cherrypick gitops-docs-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sheriff-rh
Copy link
Contributor

@ekristova you'll have to manually cherrypick to 1.10.

@eromanova97
Copy link
Contributor Author

Hello @sheriff-rh here is the manual cherry-pick to 1.10: #70612
Thank you!

@sheriff-rh
Copy link
Contributor

Merged, thank you @ekristova !

@eromanova97 eromanova97 deleted the RHDEVDOCS-5856 branch April 18, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR px-approved Signifies that Product Support has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.