-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OBSDOCS-708: Clean up collector pod taint and toleration docs #70588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@abrennan89: This pull request references OBSDOCS-708 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Mon Jan 22 18:47:38 - Prow CI generated the docs preview: https://70588--ocpdocs-pr.netlify.app |
d3a0923 to
5ee7c71
Compare
|
@abrennan89: This pull request references OBSDOCS-708 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
da011df to
90078ce
Compare
90078ce to
acaa065
Compare
acaa065 to
c4a1f29
Compare
|
@abrennan89: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| .Procedure | ||
|
|
||
| . Use the following command to add a taint to a node where you want logging collector pods to schedule logging collector pods: | ||
| + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, node-selector is used to place the pod to the specified nodes.
A real taint/tolerations scenarios is like below.
- collector pod can not be schedule to nodes which has the taint
"node-role.kubernetes.io/infra" - Add tolerations to make collector running on the infra nodes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest updating Procedure like this #63569 (review)
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
4.11+
Issue:
https://issues.redhat.com/browse/OBSDOCS-708
Link to docs preview:
QE review:
Additional information:
NOTE: This PR is only to update the collector docs. There is follow up work required for the ES and Kibana versions, which should be moved to the correct sections in the docs, and updated for Loki and OCP web console. This is out of scope for https://issues.redhat.com/browse/OBSDOCS-708