Skip to content

Conversation

@abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Jan 19, 2024

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OBSDOCS-708

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
NOTE: This PR is only to update the collector docs. There is follow up work required for the ES and Kibana versions, which should be moved to the correct sections in the docs, and updated for Loki and OCP web console. This is out of scope for https://issues.redhat.com/browse/OBSDOCS-708

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2024

@abrennan89: This pull request references OBSDOCS-708 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OBSDOCS-708

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 19, 2024

🤖 Mon Jan 22 18:47:38 - Prow CI generated the docs preview: https://70588--ocpdocs-pr.netlify.app

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2024

@abrennan89: This pull request references OBSDOCS-708 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OBSDOCS-708

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
NOTE: This PR is only to update the collector docs. There is follow up work required for the ES and Kibana versions, which should be moved to the correct sections in the docs, and updated for Loki and OCP web console. This is out of scope for https://issues.redhat.com/browse/OBSDOCS-708

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 22, 2024

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

.Procedure

. Use the following command to add a taint to a node where you want logging collector pods to schedule logging collector pods:
+
Copy link

@anpingli anpingli Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, node-selector is used to place the pod to the specified nodes.

A real taint/tolerations scenarios is like below.

  1. collector pod can not be schedule to nodes which has the taint
    "node-role.kubernetes.io/infra"
  2. Add tolerations to make collector running on the infra nodes

Copy link

@anpingli anpingli Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest updating Procedure like this #63569 (review)

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 closed this Feb 9, 2024
@abrennan89 abrennan89 deleted the OBSDOCS-708-1 branch July 2, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants