Skip to content

Conversation

mramendi
Copy link
Contributor

@mramendi mramendi commented Feb 21, 2024

Version(s):
please cp to pipelines-docs-1.14

Issue:

RHDEVDOCS 5888

Link to docs preview:

https://72005--docspreview.netlify.app/openshift-pipelines/latest/about/op-release-notes

QE review:

  • QE has approved this change.

Additional information:

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 21, 2024

🤖 Updated build preview is available at:
https://72005--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37663

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 22, 2024

* With this update, the `GetLog` endpoint of the {tekton-results} API returns raw bytes with the `text/plain` content type.

With this update, you can optionally specify a custom CA certificate in the `options.Data.config.tekton-results-api-config.DB_SSLROOTCERT` spec in the `TektonResult` CR. In this value. In this case, Tekton Results requires an SSL connection to the database server and uses this certificate for the connection.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to use the options field in the TektonResult spec, then we need to use it like this:

  options:
    configMaps:
      tekton-results-api-config:
        data:
          config: |
            DB_HOST=tekton-results-postgres-service.openshift-pipelines.svc.cluster.local
            DB_PORT=5432
            DB_NAME=tekton-results
            DB_SSLMODE=disable
            DB_SSLROOTCERT=xyz
            DB_ENABLE_AUTO_MIGRATION=true
            SERVER_PORT=8080
            PROMETHEUS_PORT=9090
            PROMETHEUS_HISTOGRAM=false
            TLS_PATH=/etc/tls
            AUTH_DISABLE=true
            AUTH_IMPERSONATE=false
            LOG_LEVEL=debug
            LOGS_API=true
            LOGS_TYPE=File
            LOGS_BUFFER_SIZE=32768
            LOGS_PATH=/logs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khrm does this mean that all the other DB settings must also, in this case, be provided in this place and not where they normally are directly in the Tekton Result spec? Or will this work:

  apiVersion: operator.tekton.dev/v1alpha1
  kind: TektonResult
  metadata:
    name: result
  spec:
    targetNamespace: openshift-pipelines
    logs_api: true
    log_level: debug
    db_port: 5432
    db_host: tekton-results-postgres-service.openshift-pipelines.svc.cluster.local
    logs_path: /logs
    logs_type: File
    logs_buffer_size: 32768
    auth_disable: true
    tls_hostname_override: tekton-results-api-service.openshift-pipelines.svc.cluster.local
    db_enable_auto_migration: true
    server_port: 8080
    prometheus_port: 9090
    options:
      configMaps:
        tekton-results-api-config:
          data:
            config:
               DB_SSLROOTCERT: <certificate>

Copy link

@khrm khrm Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All settings of that configMap should be provided in options only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khrm well, I don't know which settings are in that configMap. Those I document are listed in my example, Are any of these settings in the tekton-results-api-config configMap? Such as server_port, prometheus_port, db_port, db_host ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the settings:

DB_HOST=tekton-results-postgres-service.tekton-pipelines.svc.cluster.local DB_PORT=5432 DB_NAME=tekton-results DB_SSLMODE=disable DB_SSLROOTCERT= DB_ENABLE_AUTO_MIGRATION=true SERVER_PORT=8080 PROMETHEUS_PORT=9090 PROMETHEUS_HISTOGRAM=false TLS_PATH=/etc/tls AUTH_DISABLE=false AUTH_IMPERSONATE=true LOG_LEVEL=info LOGS_API=false LOGS_TYPE=File LOGS_BUFFER_SIZE=32768 LOGS_PATH=/logs S3_BUCKET_NAME= S3_ENDPOINT= S3_HOSTNAME_IMMUTABLE=false S3_REGION= S3_ACCESS_KEY_ID= S3_SECRET_ACCESS_KEY= S3_MULTI_PART_SIZE=5242880 GCS_BUCKET_NAME= STORAGE_EMULATOR_HOST=

Copy link

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good for Results, Triggers and Chains.

@mramendi
Copy link
Contributor Author

While a single question remains and not all signoffs are there yet, this won't change much and HAS to be merged tomorrow, so initiating peer review.

@mramendi
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 26, 2024
@kcarmichael08 kcarmichael08 added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 26, 2024
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I marked some style issues and a few things I wasn't sure about. Hope this helps!

@kcarmichael08 kcarmichael08 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 26, 2024
@khrm
Copy link

khrm commented Feb 27, 2024

Lgtm

@mramendi mramendi force-pushed the release-notes-pipelines-1.14 branch from 542eae6 to b4cc550 Compare February 27, 2024 07:38
@shipsing
Copy link
Contributor

Reviewed and verified line no 231 to 260. LGTM @mramendi. Thanks

@mramendi
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 27, 2024
@mramendi mramendi changed the title WIP: RHDEVDOCS 5888 Release Notes for Pipelines 1.14 RHDEVDOCS 5888 Release Notes for Pipelines 1.14 Feb 27, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024
@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 27, 2024
@rupalibehera
Copy link

we can merge this in next hour maybe

@JoeAldinger JoeAldinger merged commit 206b94c into openshift:pipelines-docs Feb 27, 2024
@JoeAldinger
Copy link
Contributor

/cherrypick pipelines-docs-1.14

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #72147

In response to this:

/cherrypick pipelines-docs-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.