-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS 5888 Release Notes for Pipelines 1.14 #72005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS 5888 Release Notes for Pipelines 1.14 #72005
Conversation
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37663 |
modules/op-release-notes-1-14.adoc
Outdated
|
||
* With this update, the `GetLog` endpoint of the {tekton-results} API returns raw bytes with the `text/plain` content type. | ||
|
||
With this update, you can optionally specify a custom CA certificate in the `options.Data.config.tekton-results-api-config.DB_SSLROOTCERT` spec in the `TektonResult` CR. In this value. In this case, Tekton Results requires an SSL connection to the database server and uses this certificate for the connection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to use the options field in the TektonResult spec, then we need to use it like this:
options:
configMaps:
tekton-results-api-config:
data:
config: |
DB_HOST=tekton-results-postgres-service.openshift-pipelines.svc.cluster.local
DB_PORT=5432
DB_NAME=tekton-results
DB_SSLMODE=disable
DB_SSLROOTCERT=xyz
DB_ENABLE_AUTO_MIGRATION=true
SERVER_PORT=8080
PROMETHEUS_PORT=9090
PROMETHEUS_HISTOGRAM=false
TLS_PATH=/etc/tls
AUTH_DISABLE=true
AUTH_IMPERSONATE=false
LOG_LEVEL=debug
LOGS_API=true
LOGS_TYPE=File
LOGS_BUFFER_SIZE=32768
LOGS_PATH=/logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khrm does this mean that all the other DB settings must also, in this case, be provided in this place and not where they normally are directly in the Tekton Result spec? Or will this work:
apiVersion: operator.tekton.dev/v1alpha1
kind: TektonResult
metadata:
name: result
spec:
targetNamespace: openshift-pipelines
logs_api: true
log_level: debug
db_port: 5432
db_host: tekton-results-postgres-service.openshift-pipelines.svc.cluster.local
logs_path: /logs
logs_type: File
logs_buffer_size: 32768
auth_disable: true
tls_hostname_override: tekton-results-api-service.openshift-pipelines.svc.cluster.local
db_enable_auto_migration: true
server_port: 8080
prometheus_port: 9090
options:
configMaps:
tekton-results-api-config:
data:
config:
DB_SSLROOTCERT: <certificate>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All settings of that configMap should be provided in options only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khrm well, I don't know which settings are in that configMap. Those I document are listed in my example, Are any of these settings in the tekton-results-api-config configMap? Such as server_port, prometheus_port, db_port, db_host ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the settings:
DB_HOST=tekton-results-postgres-service.tekton-pipelines.svc.cluster.local DB_PORT=5432 DB_NAME=tekton-results DB_SSLMODE=disable DB_SSLROOTCERT= DB_ENABLE_AUTO_MIGRATION=true SERVER_PORT=8080 PROMETHEUS_PORT=9090 PROMETHEUS_HISTOGRAM=false TLS_PATH=/etc/tls AUTH_DISABLE=false AUTH_IMPERSONATE=true LOG_LEVEL=info LOGS_API=false LOGS_TYPE=File LOGS_BUFFER_SIZE=32768 LOGS_PATH=/logs S3_BUCKET_NAME= S3_ENDPOINT= S3_HOSTNAME_IMMUTABLE=false S3_REGION= S3_ACCESS_KEY_ID= S3_SECRET_ACCESS_KEY= S3_MULTI_PART_SIZE=5242880 GCS_BUCKET_NAME= STORAGE_EMULATOR_HOST=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good for Results, Triggers and Chains.
While a single question remains and not all signoffs are there yet, this won't change much and HAS to be merged tomorrow, so initiating peer review. |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! I marked some style issues and a few things I wasn't sure about. Hope this helps!
Lgtm |
542eae6
to
b4cc550
Compare
Reviewed and verified line no 231 to 260. LGTM @mramendi. Thanks |
/label merge-review-needed |
we can merge this in next hour maybe |
/cherrypick pipelines-docs-1.14 |
@JoeAldinger: new pull request created: #72147 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
please cp to pipelines-docs-1.14
Issue:
RHDEVDOCS 5888
Link to docs preview:
https://72005--docspreview.netlify.app/openshift-pipelines/latest/about/op-release-notes
QE review:
Additional information: