Skip to content

RHDEVDOCS 5945 Clarify the need for Tekton Results for statistics #72359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2024
Merged

RHDEVDOCS 5945 Clarify the need for Tekton Results for statistics #72359

merged 1 commit into from
Mar 4, 2024

Conversation

mramendi
Copy link
Contributor

@mramendi mramendi commented Feb 29, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 29, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 29, 2024 •
edited
Loading

🤖 Mon Mar 04 17:05:55 - Prow CI generated the docs preview:
https://72359--ocpdocs-pr.netlify.app

@mramendi
Copy link
Contributor Author

mramendi commented Mar 4, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 4, 2024
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 4, 2024
mburke5678
mburke5678 reviewed Mar 4, 2024
View reviewed changes
modules/op-console-statistics.adoc Outdated
To view the statistic information, you must first enable the {pipelines-shortname} console plugin.
To view the statistic information, you must complete the following steps:

* Install {tekton-results}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add something like: For more infromation, see Using Tekton Results for OpenShift Pipelines observability in the Additional resources section.

Give folks some sense of where to go to install it.

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 4, 2024
@mburke5678
Copy link
Contributor

@mramendi Just one random thought. Otherwise LGTM

@aireilly aireilly changed the base branch from pipelines-docs to pipelines-docs-main March 4, 2024 16:40
kalexand-rh
kalexand-rh reviewed Mar 4, 2024
View reviewed changes
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 4, 2024

@mramendi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mramendi
Copy link
Contributor Author

mramendi commented Mar 4, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 4, 2024
aireilly
aireilly approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aireilly aireilly merged commit 65b59ad into openshift:pipelines-docs-main Mar 4, 2024
@aireilly
Copy link
Contributor

aireilly commented Mar 4, 2024

/cherrypick pipelines-docs-1.14

@openshift-cherrypick-robot
Copy link

@aireilly: new pull request created: #72564

In response to this:

/cherrypick pipelines-docs-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

@kalexand-rh kalexand-rh kalexand-rh left review comments

@aireilly aireilly aireilly approved these changes

+1 more reviewer

@ppitonak ppitonak ppitonak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mramendi @ocpdocs-previewbot @mburke5678 @aireilly @openshift-cherrypick-robot @ppitonak @kalexand-rh