Skip to content

Conversation

@EricPonvelle
Copy link
Contributor

Version(s):
enterprise-4.15+

Issue:
OSDOCS-9695

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Created a landing space for the ROSA AMIs

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 1, 2024

@EricPonvelle: This pull request references OSDOCS-9695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
enterprise-4.15+

Issue:
OSDOCS-9695

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Created a landing space for the ROSA AMIs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 1, 2024
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 1, 2024

🤖 Wed May 15 14:33:34 - Prow CI generated the docs preview:

https://72483--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_architecture/rosa-aws-amis.html

@EricPonvelle EricPonvelle force-pushed the OSDOCS-9695_ROSA-AMIs branch 8 times, most recently from c1b3ca5 to b62bdcc Compare March 4, 2024 21:00
@EricPonvelle EricPonvelle force-pushed the OSDOCS-9695_ROSA-AMIs branch from b62bdcc to df37ef8 Compare March 12, 2024 20:26
Copy link
Contributor

@jneczypor jneczypor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only left comments on the first two modules because the second two looked very similar. Just a few notes and some suggestions.

@EricPonvelle EricPonvelle force-pushed the OSDOCS-9695_ROSA-AMIs branch 3 times, most recently from 23d32d7 to 1fdcf4c Compare March 15, 2024 13:22
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2024
@EricPonvelle EricPonvelle force-pushed the OSDOCS-9695_ROSA-AMIs branch 2 times, most recently from 4e5e50a to c5cfbc8 Compare March 15, 2024 14:16
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 15, 2024
@EricPonvelle EricPonvelle force-pushed the OSDOCS-9695_ROSA-AMIs branch from c5cfbc8 to 744f46e Compare April 5, 2024 21:31
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 5, 2024
@EricPonvelle EricPonvelle force-pushed the OSDOCS-9695_ROSA-AMIs branch 2 times, most recently from bc824aa to 141187f Compare April 5, 2024 21:42
@EricPonvelle EricPonvelle force-pushed the OSDOCS-9695_ROSA-AMIs branch from 686e3cf to c5e28b5 Compare April 11, 2024 20:57
@EricPonvelle
Copy link
Contributor Author

/retest

@EricPonvelle EricPonvelle force-pushed the OSDOCS-9695_ROSA-AMIs branch from c5e28b5 to cbe41e3 Compare April 12, 2024 15:10
@EricPonvelle
Copy link
Contributor Author

/test validate-portal

1 similar comment
@EricPonvelle
Copy link
Contributor Author

/test validate-portal

@EricPonvelle EricPonvelle force-pushed the OSDOCS-9695_ROSA-AMIs branch from cbe41e3 to 3eadc73 Compare April 12, 2024 21:44
@yuwang-RH
Copy link
Member

@EricPonvelle As my comment in the JIRA ticket,
For classic cluster, it uses the override image, the id can get from rosacli, here is an example to get them for 4.15 version, rosa list versions -o json|jq -r '[.[]|select(.raw_id | contains("4.15"))]'|jq -r '.[0].image_overrides.aws[]| "\(.region.id) \(.ami)"'
For hosted-cp cluster, it uses the same OCP image, It can get from openshift-install coreos print-stream-json and also embedded in OCP installer code https://github.com/openshift/installer/blob/master/data/data/coreos/rhcos.json , for different versions, we can get the AMIs IDs in the rhos.json in different branch, like "release-4.14".  
the versions for hosted-cp in document should only include versions >=4.14, as hosteed-cp commercially supports since 4.14.
Could you update the document accordingly? 

@EricPonvelle EricPonvelle force-pushed the OSDOCS-9695_ROSA-AMIs branch 3 times, most recently from 636747d to 4a5a316 Compare May 15, 2024 13:15
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 15, 2024
@EricPonvelle EricPonvelle force-pushed the OSDOCS-9695_ROSA-AMIs branch 4 times, most recently from 6487988 to 78c49f7 Compare May 15, 2024 14:19
@EricPonvelle EricPonvelle force-pushed the OSDOCS-9695_ROSA-AMIs branch from 78c49f7 to 7dee619 Compare May 15, 2024 14:22
@openshift-ci
Copy link

openshift-ci bot commented May 15, 2024

@EricPonvelle: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelryanmcneill
Copy link
Contributor

@EricPonvelle what are the two separate AMI columns in the HCP section for? Is it that we have two separate AMIs for use? Different architectures?

@EricPonvelle
Copy link
Contributor Author

@michaelryanmcneill when @iamkirkbater and I were running the commands, we found one set of commands produced two AMIs per region. I compared that to the AMIs he found, and they did not match. Then, using this idea, I tested the various openshift-install z-stream versions, and found that even within the same Y-stream, we had different AMIs per region.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2024
@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.18 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.17. And any PR going into main must also target the latest version branch (enterprise-4.18).

If the update in your PR does NOT apply to version 4.18 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@EricPonvelle EricPonvelle deleted the OSDOCS-9695_ROSA-AMIs branch June 13, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.