-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-9695: Create the initial page for AWS AMIs in ROSA #72483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@EricPonvelle: This pull request references OSDOCS-9695 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Wed May 15 14:33:34 - Prow CI generated the docs preview: https://72483--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_architecture/rosa-aws-amis.html |
c1b3ca5 to
b62bdcc
Compare
b62bdcc to
df37ef8
Compare
jneczypor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only left comments on the first two modules because the second two looked very similar. Just a few notes and some suggestions.
23d32d7 to
1fdcf4c
Compare
4e5e50a to
c5cfbc8
Compare
c5cfbc8 to
744f46e
Compare
bc824aa to
141187f
Compare
686e3cf to
c5e28b5
Compare
|
/retest |
c5e28b5 to
cbe41e3
Compare
|
/test validate-portal |
1 similar comment
|
/test validate-portal |
cbe41e3 to
3eadc73
Compare
|
@EricPonvelle As my comment in the JIRA ticket, |
636747d to
4a5a316
Compare
6487988 to
78c49f7
Compare
78c49f7 to
7dee619
Compare
|
@EricPonvelle: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
GroceryBoyJr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@EricPonvelle what are the two separate AMI columns in the HCP section for? Is it that we have two separate AMIs for use? Different architectures? |
|
@michaelryanmcneill when @iamkirkbater and I were running the commands, we found one set of commands produced two AMIs per region. I compared that to the AMIs he found, and they did not match. Then, using this idea, I tested the various |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
The This is because your PR targets the If the update in your PR does NOT apply to version 4.18 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
Version(s):
enterprise-4.15+Issue:
OSDOCS-9695
Link to docs preview:
QE review:
Additional information:
Created a landing space for the ROSA AMIs