Skip to content

Conversation

rh-max
Copy link
Contributor

@rh-max rh-max commented Mar 6, 2024

Version(s):
serverless-docs-1.32+

Issue:
https://issues.redhat.com/browse/SRVKS-1100

Link to docs preview:
https://72687--ocpdocs-pr.netlify.app/openshift-serverless/latest/knative-serving/debugging-serverless-applications

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 6, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 6, 2024

🤖 Thu Mar 14 16:45:20 - Prow CI generated the docs preview:
https://72687--ocpdocs-pr.netlify.app

@rh-max rh-max force-pushed the srvls-debugging-knative-services branch 2 times, most recently from 3ac1158 to 90778af Compare March 6, 2024 06:38
@rh-max
Copy link
Contributor Author

rh-max commented Mar 6, 2024

@skonto @ReToCode Hi, could you PTAL? Thank you.

Copy link

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably update the order of the blocks to their likelihood:

  1. Terminal (assuming this is on the laptop)
  2. Pod
  3. Revision
  4. Ingress
  5. Route
  6. Istio routing

@rh-max
Copy link
Contributor Author

rh-max commented Mar 12, 2024

/label serverless
/label peer-review-needed

@openshift-ci openshift-ci bot added serverless Label for all Serverless PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 12, 2024
@adellape adellape self-assigned this Mar 12, 2024
@adellape adellape added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 12, 2024
@adellape adellape added this to the Continuous Release milestone Mar 12, 2024
@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 13, 2024
@rh-max
Copy link
Contributor Author

rh-max commented Mar 14, 2024

/label merge-review-needed
To the merge reviewer: please do not merge on completion, we are waiting for the GA confirmation. Thank you.

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 14, 2024
@rh-max rh-max force-pushed the srvls-debugging-knative-services branch from 0a53f2a to 283e36f Compare March 14, 2024 11:21
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 14, 2024
@rh-max
Copy link
Contributor Author

rh-max commented Mar 14, 2024

@adellape To your note about additional resources:

  • we've changed the additional resources that we are using here
  • now both of them are about a RH product/project
  • the Maistra one was explicitly agreed to by the responsible person on Serverless (Sherman Horton)
    This should clear uncertainties.

@rh-max rh-max force-pushed the srvls-debugging-knative-services branch from 283e36f to f56da95 Compare March 14, 2024 16:41
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with Max via Slack that this is ready for merge.

@adellape adellape merged commit af43ffd into openshift:serverless-docs-main Mar 14, 2024
Copy link

openshift-ci bot commented Mar 14, 2024

@rh-max: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adellape
Copy link
Contributor

/cherrypick serverless-docs-1.32

@openshift-cherrypick-robot

@adellape: new pull request created: #73191

In response to this:

/cherrypick serverless-docs-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants