Skip to content

[enterprise-4.13] OADP-3604 : openshift-velero-plugin panics on imagestream backup due to a missing secret #72906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

[enterprise-4.13] OADP-3604 : openshift-velero-plugin panics on imagestream backup due to a missing secret #72906

merged 1 commit into from
Mar 11, 2024

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Mar 9, 2024 •
edited
Loading

Cherrypicked from PR#72456

JIRA

This PR is to fix the OCP 4.13 cherry pick issue in the following PR#72456

  • Creating a new module named oadp-features-plugins-known-issues.adoc:

    • Including module in oadp-features-plugins.adoc
    • Including module in troubleshooting.adoc

Version(s):

  • OCP 4.13 → branch/enterprise-4.13

Issue:

Link to docs preview:

QE review:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 9, 2024
@aireilly
Copy link
Contributor

aireilly commented Mar 9, 2024

/retest

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 11, 2024 •
edited
Loading

🤖 Mon Mar 11 17:28:25 - Prow CI generated the docs preview:
https://72906--ocpdocs-pr.netlify.app

@anarnold97 anarnold97 force-pushed the OADP-3604-openshift-velero-plugin-panics-4-13 branch from efcdfd2 to 3b1e176 Compare March 11, 2024 13:44
@anarnold97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 11, 2024
@gwynnemonahan
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 11, 2024
gwynnemonahan
gwynnemonahan reviewed Mar 11, 2024
View reviewed changes
modules/oadp-features-plugins-known-issues.adoc Outdated
// * backup_and_restore/application_backup_and_restore/oadp-features-plugins.adoc
// * backup_and_restore/application_backup_and_restore/troubleshooting.adoc

:_content-type: CONCEPT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a note/reminder: "_content-type:" is now "_mod-docs-content-type:"

See Content Type Attributes: https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#content-type-attributes

anarnold97
anarnold97 commented Mar 11, 2024
View reviewed changes
@anarnold97 anarnold97 force-pushed the OADP-3604-openshift-velero-plugin-panics-4-13 branch from 2a79a60 to 20ef640 Compare March 11, 2024 17:13
anarnold97
anarnold97 commented Mar 11, 2024
View reviewed changes
@anarnold97
OADP-3604 : openshift-velero-plugin panics on imagestream backup due …
bda6404 
…to a missing secret 4.13

Signed-off-by: A.Arnold <anarnold@redhat.com>
@anarnold97 anarnold97 force-pushed the OADP-3604-openshift-velero-plugin-panics-4-13 branch from 5e45fd7 to bda6404 Compare March 11, 2024 17:22
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 11, 2024

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gwynnemonahan
Copy link
Contributor

Hey @anarnold97 ,

Nice work! And thank you for correcting ""_content-type:"

LGTM.

/remove-label peer-review-in-progress

/remove-label peer-review-needed

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 11, 2024
@anarnold97
Copy link
Contributor Author

@gwynnemonahan - thanks... i always forget

@anarnold97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 11, 2024
@adellape adellape self-assigned this Mar 11, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 11, 2024
@adellape adellape changed the title OADP-3604 : openshift-velero-plugin panics on imagestream backup due to a missing secret 4.13 [enterprise-4.13] OADP-3604 : openshift-velero-plugin panics on imagestream backup due to a missing secret Mar 11, 2024
@adellape adellape merged commit 0b008ad into openshift:enterprise-4.13 Mar 11, 2024
@adellape adellape added OADP Label for all OADP PRs branch/enterprise-4.13 and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gwynnemonahan gwynnemonahan gwynnemonahan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@adellape adellape

Labels

branch/enterprise-4.13 OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anarnold97 @aireilly @ocpdocs-previewbot @gwynnemonahan @adellape