Skip to content

Conversation

@dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Mar 25, 2024

Version(s):
4.14

Issue:
OSDOCS-10013

Link to docs preview:
4.14.18 z-stream release notes

QE review:

  • QE approval is not required. See peer-review checklist.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024

@dfitzmau: This pull request references OSDOCS-10013 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024

@dfitzmau: This pull request references OSDOCS-10013 which is a valid jira issue.

In response to this:

Version(s):
4.14

Issue:
OSDOCS-10013

Link to docs preview:

QE review:

  • QE approval is not required. See peer-review checklist.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 25, 2024

🤖 Mon Mar 25 17:10:17 - Prow CI generated the docs preview:
https://73669--ocpdocs-pr.netlify.app

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024

@dfitzmau: This pull request references OSDOCS-10013 which is a valid jira issue.

In response to this:

Version(s):
4.14

Issue:
OSDOCS-10013

Link to docs preview:
4.14.18 z-stream release notes

QE review:

  • QE approval is not required. See peer-review checklist.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 25, 2024
@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 25, 2024
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfitzmau one small nit and a question, sir. Otherwise, LGTM!

@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-in-progress
/label peer-review-done
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 25, 2024
@openshift-ci
Copy link

openshift-ci bot commented Mar 25, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 27, 2024
@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 27, 2024
@JoeAldinger JoeAldinger self-assigned this Mar 27, 2024
@JoeAldinger JoeAldinger added this to the Continuous Release milestone Mar 27, 2024
@JoeAldinger JoeAldinger merged commit 4042a7b into openshift:enterprise-4.14 Mar 27, 2024
@JoeAldinger JoeAldinger removed their assignment Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants