Skip to content

Conversation

@ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Mar 25, 2024

Version(s):
4.14

Issue:
4.14.18 issue

Link to docs preview:
4.14.18 async release note

QE review:

  • N/A stock text only, no bugs

@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Mar 25, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 25, 2024

🤖 Wed Mar 27 13:51:40 - Prow CI generated the docs preview:
https://73671--ocpdocs-pr.netlify.app

@ShaunaDiaz ShaunaDiaz added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 25, 2024
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 25, 2024
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-done
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/lgtm

@mletalie
Copy link
Contributor

Hello @ShaunaDiaz! Hope all is well.
Had a couple of observations (that may or may not be relevant) as well as one typo. Otherwise, LGTM...good job!

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 25, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@ShaunaDiaz ShaunaDiaz changed the title OSDOCS:9843: adds 4.14.18 release note MicroShift OSDOCS-9843: adds 4.14.18 release note MicroShift Mar 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024

@ShaunaDiaz: This pull request references OSDOCS-9843 which is a valid jira issue.

In response to this:

Version(s):
4.14

Issue:
4.14.18 issue

Link to docs preview:
4.14.18 async release note

QE review:

  • N/A stock text only, no bugs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2024
Copy link

@DanielFroehlich DanielFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@openshift-ci
Copy link

openshift-ci bot commented Mar 27, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Mar 27, 2024

@ShaunaDiaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ShaunaDiaz ShaunaDiaz merged commit b2183b3 into openshift:enterprise-4.14 Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants