[WIP] TELCODOCS-1707: Lifecycle Agent GA #74025

amolnar-gh · 2024-04-02T10:01:27Z

Version(s): 4.16+

Issue: https://issues.redhat.com/browse/TELCODOCS-1707

Link to docs preview: https://74025--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/cnf-understanding-image-based-upgrade

QE review:

QE has approved this change.

Additional information:

openshift-ci-robot · 2024-04-02T10:01:32Z

@amolnar-rh: This pull request references TELCODOCS-1707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.16

Issue: https://issues.redhat.com/browse/TELCODOCS-1707

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2024-04-02T10:08:52Z

🤖 Mon Jun 17 14:03:55 - Prow CI generated the docs preview:

openshift-ci-robot · 2024-04-02T10:09:52Z

@amolnar-rh: This pull request references TELCODOCS-1707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.16

Issue: https://issues.redhat.com/browse/TELCODOCS-1707

Link to docs preview: https://74025--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-image-based-upgrade#ztp-image-based-upgrade-concept_ztp-image-based-upgrade

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

edge_computing/ztp-image-based-upgrade.adoc

openshift-ci-robot · 2024-04-11T14:16:40Z

@amolnar-rh: This pull request references TELCODOCS-1707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.16

Issue: https://issues.redhat.com/browse/TELCODOCS-1707

Link to docs preview: https://74025--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/ztp-image-based-upgrade

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2024-06-17T14:58:06Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

modules/ztp-image-based-upgrade-installing-lifecycle-agent-using-gitops.adoc

mpmaruthu · 2024-06-18T09:43:47Z

modules/ztp-image-based-upgrade-installing-lifecycle-agent-using-gitops.adoc

+  mcp: "master"
+  sourceFiles:
+    ...
+    - fileName: OadpSecret.yaml


Suggested change

- fileName: OadpSecret.yaml

- fileName: custom-crs/OadpSecret.yaml

I think the original commit was fine (no need for "custom-crs") since we should have this in ZTP? (same for the other "custom-crs/" changes...we can revert them)

Please checkout @Missxiaoguo latest PR and just copy the examples from there openshift-kni/cnf-features-deploy#1945 ?

These source crs have now pushed to 4.16 ztp container, but we are good for now. We will need to update this a bit postGA when ready

Ah good to know! (ignore my previous comment..."custom-crs/" is good in that case!)

modules/ztp-image-based-upgrade-installing-lifecycle-agent-using-gitops.adoc

browsell

Please leave at 500

amolnar-gh · 2024-06-18T12:19:27Z

Please leave at 500

@browsell Ack, reverted the change

openshift-ci · 2024-06-18T12:23:26Z

@amolnar-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/validate-portal	`6979fb2`	link	true	`/test validate-portal`
ci/prow/validate-asciidoc	`6979fb2`	link	true	`/test validate-asciidoc`
ci/prow/deploy-preview	`6979fb2`	link	true	`/test deploy-preview`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

modules/ztp-image-based-upgrade-installing-lifecycle-agent-using-gitops.adoc

aireilly · 2024-06-24T14:24:05Z

modules/cnf-image-based-upgrade.adoc

+* `Upgrade`
+* `Rollback` (Optional)
+
+image::../images/696_OpenShift_Lifecycle_Agent_0624_0.png[Stages of the image-based upgrade]


Please add proper figure titles, eg.,

.Image Title image::/path/to/file.png[alt text, width, height]

amolnar-gh · 2024-07-04T14:17:17Z

Closing this PR as the content has been merged in separate, smaller PRs for OCP 4.16.

Implementing remaining comments in the scope of this bug: https://issues.redhat.com/browse/TELCODOCS-1932
Related open PRs:

TELCODOCS-1932: Implement post-GA SME feedback #78439 (SME feedback)
TELCODOCS-1932: Implement peer review feedback post-GA #78320 (Peer review feedback)

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 2, 2024

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 2, 2024

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2024

amolnar-gh force-pushed the TELCODOCS-1707 branch 4 times, most recently from 8c13dad to ca358d4 Compare April 8, 2024 14:45

amolnar-gh force-pushed the TELCODOCS-1707 branch from 799efe1 to 7bac574 Compare April 11, 2024 12:06

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2024

amolnar-gh force-pushed the TELCODOCS-1707 branch from 7bac574 to abf4ba0 Compare April 11, 2024 12:31

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2024

amolnar-gh force-pushed the TELCODOCS-1707 branch from abf4ba0 to 64927b9 Compare April 11, 2024 13:50

ocpdocs-vale-bot reviewed Apr 11, 2024

View reviewed changes

edge_computing/ztp-image-based-upgrade.adoc Outdated Show resolved Hide resolved

ocpdocs-vale-bot reviewed Apr 11, 2024

View reviewed changes

edge_computing/ztp-image-based-upgrade.adoc Outdated Show resolved Hide resolved

ocpdocs-vale-bot reviewed Apr 11, 2024

View reviewed changes

edge_computing/ztp-image-based-upgrade.adoc Outdated Show resolved Hide resolved

amolnar-gh force-pushed the TELCODOCS-1707 branch 2 times, most recently from 6b7d1fa to 7398541 Compare April 11, 2024 14:31

openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 11, 2024

amolnar-gh force-pushed the TELCODOCS-1707 branch 2 times, most recently from 8855afd to 95a97c6 Compare April 12, 2024 13:07

This was referenced Jun 14, 2024

TELCODOCS-1707: Preparing configmap objects GitOps #77475

Merged

TELCODOCS-1707: Add performing upgrade non-GitOps #77477

Merged

Add Understanding assembly, modules, and diagrams

30b9576

amolnar-gh force-pushed the TELCODOCS-1707 branch from 625ef23 to fa1ed8d Compare June 17, 2024 13:55

amolnar-gh mentioned this pull request Jun 17, 2024

TELCODOCS-1707: Add Performing upgrade GitOps #77561

Merged

1 task

amolnar-gh force-pushed the TELCODOCS-1707 branch from fa1ed8d to cdb1247 Compare June 17, 2024 14:57

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2024

amolnar-gh added 8 commits June 17, 2024 16:07

Add Preparing/Configuring shared container dir

1dfa0bc

Add Preparing/Installing Operators

0bced9c

Add Preparing/Generate seed image

edeb1ea

Add Preparing/ConfigMap objects nonGitOps

5b8a575

Add Preparing/ConfigMap objects GitOps

980c518

Add Performing upgrade non-GitOps

80596b0

Add Performing upgrade GitOps

9def6a8

Add xrefs

f3e30fc

amolnar-gh force-pushed the TELCODOCS-1707 branch from cdb1247 to f3e30fc Compare June 17, 2024 15:07

mpmaruthu suggested changes Jun 18, 2024

View reviewed changes

modules/ztp-image-based-upgrade-installing-lifecycle-agent-using-gitops.adoc Show resolved Hide resolved

mpmaruthu suggested changes Jun 18, 2024

View reviewed changes

Update Installing Operators via GitOps

6979fb2

browsell reviewed Jun 18, 2024

View reviewed changes

amolnar-gh force-pushed the TELCODOCS-1707 branch from 54fac58 to 6979fb2 Compare June 18, 2024 12:17

Missxiaoguo reviewed Jun 19, 2024

View reviewed changes

modules/ztp-image-based-upgrade-installing-lifecycle-agent-using-gitops.adoc Show resolved Hide resolved

modules/ztp-image-based-upgrade-installing-lifecycle-agent-using-gitops.adoc Show resolved Hide resolved

amolnar-gh mentioned this pull request Jun 24, 2024

TELCODOCS-1707: Add xrefs #77947

Merged

1 task

aireilly reviewed Jun 24, 2024

View reviewed changes

amolnar-gh mentioned this pull request Jul 3, 2024

TELCODOCS-1932: Implement post-GA SME feedback #78439

Merged

1 task

amolnar-gh closed this Jul 9, 2024

	- fileName: OadpSecret.yaml
	- fileName: custom-crs/OadpSecret.yaml

[WIP] TELCODOCS-1707: Lifecycle Agent GA #74025

[WIP] TELCODOCS-1707: Lifecycle Agent GA #74025

Uh oh!

Conversation

amolnar-gh commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 2, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 2, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 11, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-robot commented Jun 17, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mpmaruthu Jun 18, 2024

Choose a reason for hiding this comment

Uh oh!

pixelsoccupied Jun 24, 2024

Choose a reason for hiding this comment

Uh oh!

Missxiaoguo Jun 24, 2024

Choose a reason for hiding this comment

Uh oh!

pixelsoccupied Jun 24, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

browsell left a comment

Choose a reason for hiding this comment

Uh oh!

amolnar-gh commented Jun 18, 2024

Uh oh!

openshift-ci bot commented Jun 18, 2024

Uh oh!

Uh oh!

Uh oh!

aireilly Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amolnar-gh commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

amolnar-gh commented Apr 2, 2024 •

edited

Loading

openshift-ci-robot commented Apr 2, 2024 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Apr 2, 2024 •

edited

Loading

openshift-ci-robot commented Apr 2, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 11, 2024 •

edited by openshift-ci bot

Loading

aireilly Jun 24, 2024 •

edited

Loading

amolnar-gh commented Jul 4, 2024 •

edited

Loading