RHDEVDOCS 5935 Add pipelinerun and builder artifacts to chains config #74503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/S
|
🤖 Fri Apr 12 22:07:50 - Prow CI generated the docs preview: |
modules/op-supported-parameters-tekton-chains-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/op-supported-parameters-tekton-chains-configuration.adoc
Outdated
Show resolved
Hide resolved
| | `+https://tekton.dev/chains/v2+` | ||
|
|
||
| | `builddefinition.buildtype` | ||
| | The build type for in-toto attestation. When this parameter is `\https://tekton.dev/chains/v2/slsa`, {tekton-chains} records in-toto attestations in strict conformance with the SLSA v1.0 specification. When this parameter is `\https://tekton.dev/chains/v2/slsa-tekton`, {tekton-chains} records in-toto attestations with additional information such as the labels and annotations in each task run and pipeline run, and also adds each task in a pipeline run under `resolvedDependencies`. |
There was a problem hiding this comment.
Suggested change
| | The build type for in-toto attestation. When this parameter is `\https://tekton.dev/chains/v2/slsa`, {tekton-chains} records in-toto attestations in strict conformance with the SLSA v1.0 specification. When this parameter is `\https://tekton.dev/chains/v2/slsa-tekton`, {tekton-chains} records in-toto attestations with additional information such as the labels and annotations in each task run and pipeline run, and also adds each task in a pipeline run under `resolvedDependencies`. | |
| | The build type for in-toto attestation. When this parameter is `\https://tekton.dev/chains/v2/slsa`, {tekton-chains} records in-toto attestations in strict conformance with the SLSA v1.0 specification. When this parameter is `\https://tekton.dev/chains/v2/slsa-tekton`, {tekton-chains} records in-toto attestations with additional information such as the labels and annotations in each taskrun and pipelinerun, and also adds each pipeline task in a pipelinerun under `resolvedDependencies`. |
|
LGTM |
ppitonak
approved these changes
Apr 12, 2024
mramendi
force-pushed
the
RHDEVDOCS=5935
branch
from
3574e02 to
d8730ca
Compare
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
lpettyjo
added
peer-review-in-progress
lpettyjo
reviewed
Apr 12, 2024
| | `x509` | ||
|
|
||
| | `artifacts.pipelinerun.enable-deep-inspection` | ||
| | When this parameter is `true`, {tekton-chains} records the results of the child task runs of a pipeline run. When this parameter is `false`, {tekton-chains} records the results of the pipeline run but not of its child task runs. |
There was a problem hiding this comment.
Add a comma before "but".
| | `+https://tekton.dev/chains/v2+` | ||
|
|
||
| | `builddefinition.buildtype` | ||
| | The build type for in-toto attestation. When this parameter is `\https://tekton.dev/chains/v2/slsa`, {tekton-chains} records in-toto attestations in strict conformance with the SLSA v1.0 specification. When this parameter is `\https://tekton.dev/chains/v2/slsa-tekton`, {tekton-chains} records in-toto attestations with additional information such as the labels and annotations in each `TaskRun` and `PipelineRun` object, and also adds each task in a `PipelineRun` object under `resolvedDependencies`. |
There was a problem hiding this comment.
Add command before "such".
lpettyjo
added
peer-review-done
mramendi
force-pushed
the
RHDEVDOCS=5935
branch
from
d8730ca to
8aeb373
Compare
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
|
@mramendi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
kcarmichael08
added
merge-review-in-progress
|
/cherrypick pipelines-docs-1.14 |
|
@kcarmichael08: new pull request created: #74637 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s):
please cp to pipelines-docs-1.14
Issue:
RHDEVDOCS 5935
Link to docs preview:
https://74503--ocpdocs-pr.netlify.app/openshift-pipelines/latest/secure/using-tekton-chains-for-openshift-pipelines-supply-chain-security.html#supported-parameters-tekton-chains-configuration_using-tekton-chains-for-openshift-pipelines-supply-chain-security
see Table 2 and Table 5
QE review:
Additional information: