-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS-5958: Table header correction for tables using the ** style in it's headers #74878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS-5958: Table header correction for tables using the ** style in it's headers #74878
Conversation
|
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
eromanova97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you!
(just added one note comment in case the second row of the matrix should be in bold)
86c0b0f to
16d0b8a
Compare
16d0b8a to
36553c2
Compare
|
/label peer-review-needed |
|
@Dhruv-Soni11 LGTM. I am not clear on your response to the comment on bolding the second row of one table. You suggested that you "fixed" it; but I don't see the change, if you intended to add the bold. |
9a73392 to
eb9af31
Compare
|
@Dhruv-Soni11: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hi @sheriff-rh, I have gone ahead and rebased the branch to ensure there aren't any conflicts. Added the merge-review-needed label here to ensure that we can resume the process. Thanks. |
|
/label merge-review-needed |
|
Correct @Dhruv-Soni11 , if a PR is ready for merge, add the |
|
/cherrypick gitops-docs-1.10 |
|
/cherrypick gitops-docs-1.11 |
|
/cherrypick gitops-docs-1.12 |
|
@Srivaralakshmi: #74878 failed to apply on top of branch "gitops-docs-1.10": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Srivaralakshmi: #74878 failed to apply on top of branch "gitops-docs-1.11": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Srivaralakshmi: new pull request created: #75900 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick gitops-docs-1.13 |
|
@Srivaralakshmi: new pull request created: #75901 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): GitOps 1.10, GitOps 1.11, GitOps 1.12, and GitOps 1.13
Issue: https://issues.redhat.com/browse/RHDEVDOCS-5958
Link to docs preview: The following tables include the table header change:
SME review: @reginapizza
QE review: @varshab1210
Internal Peer review: @eromanova97
Peer review:
QE review: