Skip to content

Conversation

@Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Apr 19, 2024

Version(s): GitOps 1.10, GitOps 1.11, GitOps 1.12, and GitOps 1.13
Issue: https://issues.redhat.com/browse/RHDEVDOCS-5958

Link to docs preview: The following tables include the table header change:

SME review: @reginapizza
QE review: @varshab1210
Internal Peer review: @eromanova97
Peer review:

QE review:

  • QE has approved this change.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 19, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 19, 2024
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 19, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.10, GitOps 1.11, GitOps 1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5958

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 19, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.10, GitOps 1.11, GitOps 1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5958

Link to docs preview:

SME review: @reginapizza
QE review: @varshab1210
Peer review:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 19, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5958

Link to docs preview:

SME review: @reginapizza
QE review: @varshab1210
Peer review:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5958

Link to docs preview:

The following tables include the table header change:

Monitoring the GitOps Operator performance - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-the-gitops-operator-performance.html

Argo CD custom resource properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-cd-properties_argo-cd-cr-component-properties

In-built permissions for cluster configuration - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations#gitops-inbuilt-permissions-for-cluster-config_configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations

Modifying RHSSO resource requests/limits - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/accesscontrol_usermanagement/configuring-argo-cd-rbac#modifying-rhsso-resource-requests-limits_configuring-argo-cd-rbac

Repo server properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-repo-server-properties_argo-cd-cr-component-properties

Compatibility and support matrix - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes#GitOps-compatibility-support-matrix_gitops-release-notes

Monitoring the GitOps Operator performance - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-the-gitops-operator-performance

SME review: @reginapizza
QE review: @varshab1210
Peer review:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5958

Link to docs preview:

The following tables include the table header change:

Argo CD custom resource properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-cd-properties_argo-cd-cr-component-properties

In-built permissions for cluster configuration - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations#gitops-inbuilt-permissions-for-cluster-config_configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations

Modifying RHSSO resource requests/limits - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/accesscontrol_usermanagement/configuring-argo-cd-rbac#modifying-rhsso-resource-requests-limits_configuring-argo-cd-rbac

Repo server properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-repo-server-properties_argo-cd-cr-component-properties

Compatibility and support matrix - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes#GitOps-compatibility-support-matrix_gitops-release-notes

Monitoring the GitOps Operator performance - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-the-gitops-operator-performance

SME review: @reginapizza
QE review: @varshab1210
Peer review:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.

In response to this:

Version(s): GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13

Issue: https://issues.redhat.com/browse/RHDEVDOCS-5958

Link to docs preview: The following tables include the table header change:

SME review: @reginapizza
QE review: @varshab1210
Peer review:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.

In response to this:

Version(s): GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13

Issue: https://issues.redhat.com/browse/RHDEVDOCS-5958

Link to docs preview: The following tables include the table header change:

SME review: @reginapizza
QE review: @varshab1210
Peer review:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.

In response to this:

Version(s): GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13

Issue: https://issues.redhat.com/browse/RHDEVDOCS-5958

Link to docs preview: The following tables include the table header change:

SME review: @reginapizza
QE review: @varshab1210
Peer review:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.

In response to this:

Version(s): GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13

Issue: https://issues.redhat.com/browse/RHDEVDOCS-5958

Link to docs preview: The following tables include the table header change:

SME review: @reginapizza
QE review: @varshab1210
Internal Peer review: @eromanova97
Peer review:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@eromanova97 eromanova97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

(just added one note comment in case the second row of the matrix should be in bold)

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 1, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 1, 2024
@Dhruv-Soni11
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 1, 2024
@mburke5678 mburke5678 added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 1, 2024
@mburke5678
Copy link
Contributor

@Dhruv-Soni11 LGTM. I am not clear on your response to the comment on bolding the second row of one table. You suggested that you "fixed" it; but I don't see the change, if you intended to add the bold.

@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 1, 2024
@sheriff-rh sheriff-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label May 10, 2024
@openshift-ci
Copy link

openshift-ci bot commented May 14, 2024

@Dhruv-Soni11: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Dhruv-Soni11
Copy link
Contributor Author

Dhruv-Soni11 commented May 14, 2024

Hi @sheriff-rh, I have gone ahead and rebased the branch to ensure there aren't any conflicts. Added the merge-review-needed label here to ensure that we can resume the process. Thanks.

@Dhruv-Soni11
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 14, 2024
@sheriff-rh
Copy link
Contributor

Correct @Dhruv-Soni11 , if a PR is ready for merge, add the merge-review-label as you have done 👍 this week's rotation of merge squad will pick it up when they can.

@Srivaralakshmi Srivaralakshmi merged commit b3dca73 into openshift:gitops-docs-main May 14, 2024
@Srivaralakshmi Srivaralakshmi added merge-review-in-progress Signifies that the merge review team is reviewing this PR sme-review-done Service Delivery issues that have been reviewed by SRE, PMs, Engineering, QE, etc. qe-approved Signifies that QE has signed off on this PR lgtm Indicates that a PR is ready to be merged. gitops peer-review-done Signifies that the peer review team has reviewed this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 14, 2024
@Srivaralakshmi Srivaralakshmi added this to the Continuous Release milestone May 14, 2024
@Srivaralakshmi
Copy link
Contributor

/cherrypick gitops-docs-1.10

@Srivaralakshmi
Copy link
Contributor

/cherrypick gitops-docs-1.11

@Srivaralakshmi
Copy link
Contributor

/cherrypick gitops-docs-1.12

@openshift-cherrypick-robot

@Srivaralakshmi: #74878 failed to apply on top of branch "gitops-docs-1.10":

Applying: RHDEVDOCS-5958: Table header correction using the ** style
Using index info to reconstruct a base tree...
M	modules/gitops-argo-cd-properties.adoc
M	modules/go-compatibility-and-support-matrix.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/go-compatibility-and-support-matrix.adoc
CONFLICT (content): Merge conflict in modules/go-compatibility-and-support-matrix.adoc
Auto-merging modules/gitops-argo-cd-properties.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHDEVDOCS-5958: Table header correction using the ** style
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick gitops-docs-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@Srivaralakshmi: #74878 failed to apply on top of branch "gitops-docs-1.11":

Applying: RHDEVDOCS-5958: Table header correction using the ** style
Using index info to reconstruct a base tree...
M	modules/gitops-argo-cd-properties.adoc
M	modules/go-compatibility-and-support-matrix.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/go-compatibility-and-support-matrix.adoc
CONFLICT (content): Merge conflict in modules/go-compatibility-and-support-matrix.adoc
Auto-merging modules/gitops-argo-cd-properties.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHDEVDOCS-5958: Table header correction using the ** style
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick gitops-docs-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@Srivaralakshmi: new pull request created: #75900

In response to this:

/cherrypick gitops-docs-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Srivaralakshmi
Copy link
Contributor

/cherrypick gitops-docs-1.13

@openshift-cherrypick-robot

@Srivaralakshmi: new pull request created: #75901

In response to this:

/cherrypick gitops-docs-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitops jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sme-review-done Service Delivery issues that have been reviewed by SRE, PMs, Engineering, QE, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants